Remove support for the web manifest icon density member.

Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
   in pixels, with the ideal and minimum sizes computed using the
   device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
Committed: https://crrev.com/eaaf62daff59322dc31bebca2933c166c3f92e88
Cr-Commit-Position: refs/heads/master@{#388946}

[dominickn, 2016-04-20 06:03:32]

Description was changed from

==========
Remove support for the density member in web manifest icons.

The web app manifest specification has been changed to remove the
density member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from the manifest parser
and manifest icon selector. The icon selector now purely selects icons
based on their size in pixels, with the ideal and minimum sizes computed
using the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web app manifest specification has been changed to remove the
density member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from the manifest parser
and manifest icon selector. The icon selector now purely selects icons
based on their size in pixels, with the ideal and minimum sizes computed
using the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL.

BUG=603848
==========

[dominickn, 2016-04-20 06:03:32]

dominickn@chromium.org changed reviewers:
+ mlamouri@chromium.org

[dominickn, 2016-04-20 06:59:18]

PTAL, thanks!

[dominickn, 2016-04-20 06:59:32]

Description was changed from

==========
Remove support for the web manifest icon density member.

The web app manifest specification has been changed to remove the
density member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from the manifest parser
and manifest icon selector. The icon selector now purely selects icons
based on their size in pixels, with the ideal and minimum sizes computed
using the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the
density member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from the manifest parser
and manifest icon selector. The icon selector now purely selects icons
based on their size in pixels, with the ideal and minimum sizes computed
using the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL.

BUG=603848
==========

[dominickn, 2016-04-20 06:59:56]

Description was changed from

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the
density member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from the manifest parser
and manifest icon selector. The icon selector now purely selects icons
based on their size in pixels, with the ideal and minimum sizes computed
using the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from the manifest parser
and manifest icon selector. The icon selector now purely selects icons
based on their size in pixels, with the ideal and minimum sizes computed
using the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL.

BUG=603848
==========

[dominickn, 2016-04-20 07:01:12]

Description was changed from

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from the manifest parser
and manifest icon selector. The icon selector now purely selects icons
based on their size in pixels, with the ideal and minimum sizes computed
using the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include the manifest parser ignoring any density
members, and the manifest icon selector now purely selects icons based
on their size in pixels, with the ideal and minimum sizes computed using
the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

[dominickn, 2016-04-20 10:54:05]

Description was changed from

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include the manifest parser ignoring any density
members, and the manifest icon selector now purely selects icons based
on their size in pixels, with the ideal and minimum sizes computed using
the device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
    in pixels, with the ideal and minimum sizes computed using the
    device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

[dominickn, 2016-04-20 10:54:26]

Description was changed from

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
    in pixels, with the ideal and minimum sizes computed using the
    device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
   in pixels, with the ideal and minimum sizes computed using the
   device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

[mlamouri (slow - plz ping), 2016-04-21 13:08:40]

lgtm \o/

https://codereview.chromium.org/1901363003/diff/1/chrome/browser/manifest/man...
File chrome/browser/manifest/manifest_icon_selector_unittest.cc (right):

https://codereview.chromium.org/1901363003/diff/1/chrome/browser/manifest/man...
chrome/browser/manifest/manifest_icon_selector_unittest.cc:195:
TEST_F(ManifestIconSelectorTest, DeviceDensityFirst) {
nit: change test name? Like "UseDeviceDensity"?

[dominickn, 2016-04-21 13:57:36]

dominickn@chromium.org changed reviewers:
+ nasko@chromium.org

[dominickn, 2016-04-21 14:14:43]

Thanks!

+nasko: PTAL at content/

https://codereview.chromium.org/1901363003/diff/1/chrome/browser/manifest/man...
File chrome/browser/manifest/manifest_icon_selector_unittest.cc (right):

https://codereview.chromium.org/1901363003/diff/1/chrome/browser/manifest/man...
chrome/browser/manifest/manifest_icon_selector_unittest.cc:195:
TEST_F(ManifestIconSelectorTest, DeviceDensityFirst) {
On 2016/04/21 13:08:40, Mounir Lamouri wrote:
> nit: change test name? Like "UseDeviceDensity"?

Done.

[nasko, 2016-04-21 18:42:44]

content/ LGTM

[dominickn, 2016-04-21 23:15:12]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-04-21 23:15:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1901363003/#ps20001
(title: "Rename test")

[commit-bot: I haz the power, 2016-04-21 23:15:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901363003/20001

[commit-bot: I haz the power, 2016-04-21 23:20:16]

Description was changed from

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
   in pixels, with the ideal and minimum sizes computed using the
   device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
   in pixels, with the ideal and minimum sizes computed using the
   device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

[commit-bot: I haz the power, 2016-04-21 23:20:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:41:22]

Description was changed from

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
   in pixels, with the ideal and minimum sizes computed using the
   device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848
==========

to

==========
Remove support for the web manifest icon density member.

The web manifest specification has been changed to remove the density
member, as this item was poorly understood and deployed
(discussion at https://github.com/w3c/manifest/issues/450).

This CL removes support for the density member from Chromium.
Substantive changes include:
 * the manifest parser ignores any density members
 * the manifest icon selector now purely selects icons based on their size
   in pixels, with the ideal and minimum sizes computed using the
   device's scale factor.

The manifest icon selector tests are improved and clarified in this CL
now that they do not need to use density.

BUG=603848

Committed: https://crrev.com/eaaf62daff59322dc31bebca2933c166c3f92e88
Cr-Commit-Position: refs/heads/master@{#388946}
==========

[commit-bot: I haz the power, 2016-04-22 19:41:23]

Patchset 2 (id:??) landed as
https://crrev.com/eaaf62daff59322dc31bebca2933c166c3f92e88
Cr-Commit-Position: refs/heads/master@{#388946}