Remove support for the web manifest icon density member.

content/renderer/manifest/manifest_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/manifest/manifest_parser.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 613 matching lines @@
     Manifest manifest =
         ParseManifest("{ \"icons\": [ {\"src\": \"\", \"type\": 42 } ] }");
     EXPECT_TRUE(manifest.icons[0].type.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'type' ignored,"
               " type string expected.",
               errors()[0]);
   }
 }
 
-TEST_F(ManifestParserTest, IconDensityParseRules) {
-  // Smoke test.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\": 42 } ] }");
-    EXPECT_EQ(manifest.icons[0].density, 42);
-    EXPECT_EQ(0u, GetErrorCount());
-  }
-
-  // Decimal value.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\": 2.5 } ] }");
-    EXPECT_EQ(manifest.icons[0].density, 2.5);
-    EXPECT_EQ(0u, GetErrorCount());
-  }
-
-  // Parse fail if it isn't a float.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\": {} } ] }");
-    EXPECT_EQ(manifest.icons[0].density, Manifest::Icon::kDefaultDensity);
-    EXPECT_EQ(1u, GetErrorCount());
-    EXPECT_EQ("Manifest parsing error: icon 'density' ignored, "
-              "must be float greater than 0.",
-              errors()[0]);
-  }
-
-  // Parse fail if it isn't a float.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\":\"2\" } ] }");
-    EXPECT_EQ(manifest.icons[0].density, Manifest::Icon::kDefaultDensity);
-    EXPECT_EQ(1u, GetErrorCount());
-    EXPECT_EQ("Manifest parsing error: icon 'density' ignored, "
-              "must be float greater than 0.",
-              errors()[0]);
-  }
-
-  // Edge case: 1.0.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\": 1.00 } ] }");
-    EXPECT_EQ(manifest.icons[0].density, 1);
-    EXPECT_EQ(0u, GetErrorCount());
-  }
-
-  // Edge case: values between 0.0 and 1.0 are allowed.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\": 0.42 } ] }");
-    EXPECT_EQ(manifest.icons[0].density, 0.42);
-    EXPECT_EQ(0u, GetErrorCount());
-  }
-
-  // 0 is an invalid value.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\": 0.0 } ] }");
-    EXPECT_EQ(manifest.icons[0].density, Manifest::Icon::kDefaultDensity);
-    EXPECT_EQ(1u, GetErrorCount());
-    EXPECT_EQ("Manifest parsing error: icon 'density' ignored, "
-              "must be float greater than 0.",
-              errors()[0]);
-  }
-
-  // Negative values are invalid.
-  {
-    Manifest manifest =
-        ParseManifest("{ \"icons\": [ {\"src\": \"\", \"density\": -2.5 } ] }");
-    EXPECT_EQ(manifest.icons[0].density, Manifest::Icon::kDefaultDensity);
-    EXPECT_EQ(1u, GetErrorCount());
-    EXPECT_EQ("Manifest parsing error: icon 'density' ignored, "
-              "must be float greater than 0.",
-              errors()[0]);
-  }
-}
-
 TEST_F(ManifestParserTest, IconSizesParseRules) {
   // Smoke test.
   {
     Manifest manifest = ParseManifest("{ \"icons\": [ {\"src\": \"\","
         "\"sizes\": \"42x42\" } ] }");
     EXPECT_EQ(manifest.icons[0].sizes.size(), 1u);
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Trim whitespaces.
@@ skipping 653 matching lines @@
     Manifest manifest = ParseManifest("{ \"gcm_sender_id\": 42 }");
     EXPECT_TRUE(manifest.gcm_sender_id.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'gcm_sender_id' ignored,"
               " type string expected.",
               errors()[0]);
   }
 }
 
 } // namespace content