Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 190133003: Revert 255512 "Introduce a mock ui_unittests Framework for loadi..." (Closed)

Created:
6 years, 9 months ago by tapted
Modified:
6 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255512 "Introduce a mock ui_unittests Framework for loadi..." All the chromium.mac bots were happy, but the official builder didn't like it. > Introduce a mock ui_unittests Framework for loading resources. > > This allows ui_unittests to stop depending on the chrome framework. > > On Mac, this creates (e.g.) > - out/ui_unittests Framework.framework/ > +-- Resources -> Versions/A/Resources > \-- Versions > \-- A > \-- Resources > +-- Info.plist > +-- am.lproj > | \-- locale.pak > +-- ... > +-- chrome_100_percent.pak -> ui_test.pak > +-- ... > +-- en.lproj > | \-- locale.pak > +-- ... > > On other platforms, out/ui_test.pak is loaded directly and > out/ui_unittests_strings/ is set as the locale folder (for tests that > load en-US.pak from there). ui_unittests currently depends on > out/locales/ which is only created when Chrome is built. > > Note that ui_unittests does not currently succeed in a clobber build > (crbug.com/347851), so that missing dependency is fixed by this change > as well. > > BUG=331669, 35878, 347851 > TEST=ui_unittests should build and run after clobbering the build folder > > Review URL: https://codereview.chromium.org/152543005 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -114 lines) Patch
M trunk/src/ui/base/l10n/time_format_unittest.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M trunk/src/ui/base/strings/ui_strings.gyp View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/ui/base/test/framework-Info.plist View 1 chunk +0 lines, -18 lines 0 comments Download
M trunk/src/ui/base/test/run_all_unittests.cc View 1 chunk +18 lines, -25 lines 0 comments Download
M trunk/src/ui/ui_unittests.gyp View 3 chunks +1 line, -18 lines 0 comments Download
D trunk/src/ui/ui_unittests_bundle.gypi View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tapted
6 years, 9 months ago (2014-03-07 04:41:55 UTC) #1
tapted
6 years, 9 months ago (2014-03-07 04:42:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255528 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698