DescriptionRevert 255512 "Introduce a mock ui_unittests Framework for loadi..."
All the chromium.mac bots were happy, but the official builder didn't like it.
> Introduce a mock ui_unittests Framework for loading resources.
>
> This allows ui_unittests to stop depending on the chrome framework.
>
> On Mac, this creates (e.g.)
> - out/ui_unittests Framework.framework/
> +-- Resources -> Versions/A/Resources
> \-- Versions
> \-- A
> \-- Resources
> +-- Info.plist
> +-- am.lproj
> | \-- locale.pak
> +-- ...
> +-- chrome_100_percent.pak -> ui_test.pak
> +-- ...
> +-- en.lproj
> | \-- locale.pak
> +-- ...
>
> On other platforms, out/ui_test.pak is loaded directly and
> out/ui_unittests_strings/ is set as the locale folder (for tests that
> load en-US.pak from there). ui_unittests currently depends on
> out/locales/ which is only created when Chrome is built.
>
> Note that ui_unittests does not currently succeed in a clobber build
> (crbug.com/347851), so that missing dependency is fixed by this change
> as well.
>
> BUG=331669, 35878, 347851
> TEST=ui_unittests should build and run after clobbering the build folder
>
> Review URL: https://codereview.chromium.org/152543005
TBR=tapted@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255528
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|