Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: trunk/src/ui/base/test/run_all_unittests.cc

Issue 190133003: Revert 255512 "Introduce a mock ui_unittests Framework for loadi..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ui/base/test/framework-Info.plist ('k') | trunk/src/ui/ui_unittests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ui/base/test/run_all_unittests.cc
===================================================================
--- trunk/src/ui/base/test/run_all_unittests.cc (revision 255525)
+++ trunk/src/ui/base/test/run_all_unittests.cc (working copy)
@@ -52,34 +52,27 @@
ui::RegisterPathProvider();
gfx::RegisterPathProvider();
- base::FilePath exe_path;
- PathService::Get(base::DIR_EXE, &exe_path);
-
#if defined(OS_MACOSX) && !defined(OS_IOS)
- // On Mac, a test Framework bundle is created that links locale.pak and
- // chrome_100_percent.pak at the appropriate places to ui_test.pak.
- base::mac::SetOverrideFrameworkBundlePath(
- exe_path.AppendASCII("ui_unittests Framework.framework"));
- ui::ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
+ // Look in the framework bundle for resources.
+ // TODO(port): make a resource bundle for non-app exes. What's done here
+ // isn't really right because this code needs to depend on chrome_dll
+ // being built. This is inappropriate in app.
+ base::FilePath path;
+ PathService::Get(base::DIR_EXE, &path);
+#if defined(GOOGLE_CHROME_BUILD)
+ path = path.AppendASCII("Google Chrome Framework.framework");
+#elif defined(CHROMIUM_BUILD)
+ path = path.AppendASCII("Chromium Framework.framework");
+#else
+#error Unknown branding
+#endif
+ base::mac::SetOverrideFrameworkBundlePath(path);
+#endif // defined(OS_MACOSX) && !defined(OS_IOS)
-#elif defined(OS_IOS) || defined(OS_ANDROID)
- // On iOS, the ui_unittests binary is itself a mini bundle, with resources
- // built in. On Android, ui_unittests_apk provides the necessary framework.
+ // TODO(tfarina): This loads chrome_100_percent.pak and thus introduces a
+ // dependency on chrome/, we don't want that here, so change this to
+ // InitSharedInstanceWithPakPath().
ui::ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
-
-#else
- // On other platforms, the (hardcoded) paths for chrome_100_percent.pak and
- // locale.pak get populated by later build steps. To avoid clobbering them,
- // load the test .pak files directly.
- ui::ResourceBundle::InitSharedInstanceWithPakPath(
- exe_path.AppendASCII("ui_test.pak"));
-
- // ui_unittests can't depend on the locales folder which Chrome will make
- // later, so use the path created by ui_unittest_strings.
- PathService::Override(
- ui::DIR_LOCALES,
- exe_path.AppendASCII("ui_unittests_strings"));
-#endif
}
void UIBaseTestSuite::Shutdown() {
« no previous file with comments | « trunk/src/ui/base/test/framework-Info.plist ('k') | trunk/src/ui/ui_unittests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698