Support excluding Google Test extensions

Support excluding Google Test extensions

GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.

Committed: https://crrev.com/ccff0d0ca88dc927380c9d0d4315af5faeee626d
Cr-Commit-Position: refs/heads/master@{#388400}

[Petr Hosek, 2016-04-20 00:54:16]

Patchset #1 (id:1) has been deleted

[Petr Hosek, 2016-04-20 00:59:00]

Description was changed from

==========
Support excluding Google Test extensions

GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.
==========

to

==========
Support excluding Google Test extensions

GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.
==========

[Petr Hosek, 2016-04-20 00:59:00]

phosek@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-20 01:17:24]

lgtm

[Petr Hosek, 2016-04-20 01:39:33]

The CQ bit was checked by phosek@chromium.org

[commit-bot: I haz the power, 2016-04-20 01:39:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901313002/20001

[commit-bot: I haz the power, 2016-04-20 01:44:45]

Description was changed from

==========
Support excluding Google Test extensions

GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.
==========

to

==========
Support excluding Google Test extensions

GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.
==========

[commit-bot: I haz the power, 2016-04-20 01:44:46]

Committed patchset #1 (id:20001)

[kjellander_chromium, 2016-04-20 05:38:45]

kjellander@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2016-04-20 05:38:45]

https://codereview.chromium.org/1901313002/diff/20001/build_overrides/gtest.gni
File build_overrides/gtest.gni (right):

https://codereview.chromium.org/1901313002/diff/20001/build_overrides/gtest.g...
build_overrides/gtest.gni:5: # Exclude support for registering main function in
multi-process tests.
Shouldn't "Exclude" be "Include" here?

https://codereview.chromium.org/1901313002/diff/20001/build_overrides/gtest.g...
build_overrides/gtest.gni:8: # Exclude support for platform-specific operations
across unit tests.
Same here.

[Petr Hosek, 2016-04-20 15:59:44]

https://codereview.chromium.org/1901313002/diff/20001/build_overrides/gtest.gni
File build_overrides/gtest.gni (right):

https://codereview.chromium.org/1901313002/diff/20001/build_overrides/gtest.g...
build_overrides/gtest.gni:5: # Exclude support for registering main function in
multi-process tests.
On 2016/04/20 05:38:45, kjellander (chromium) wrote:
> Shouldn't "Exclude" be "Include" here?

I've followed the pattern used in other .gni files in //build_overrides.

https://codereview.chromium.org/1901313002/diff/20001/build_overrides/gtest.g...
build_overrides/gtest.gni:8: # Exclude support for platform-specific operations
across unit tests.
On 2016/04/20 05:38:45, kjellander (chromium) wrote:
> Same here.

Ditto.

[commit-bot: I haz the power, 2016-04-22 19:19:48]

Description was changed from

==========
Support excluding Google Test extensions

GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.
==========

to

==========
Support excluding Google Test extensions

GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.

Committed: https://crrev.com/ccff0d0ca88dc927380c9d0d4315af5faeee626d
Cr-Commit-Position: refs/heads/master@{#388400}
==========

[commit-bot: I haz the power, 2016-04-22 19:19:49]

Patchset 1 (id:??) landed as
https://crrev.com/ccff0d0ca88dc927380c9d0d4315af5faeee626d
Cr-Commit-Position: refs/heads/master@{#388400}