build_overrides/gtest.gni - Issue 1901313002: Support excluding Google Test extensions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/gtest.gni

Issue 1901313002: Support excluding Google Test extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Exclude support for registering main function in multi-process tests.
	kjellander_chromium 2016/04/20 05:38:45 Shouldn't "Exclude" be "Include" here? Shouldn't "Exclude" be "Include" here? Petr Hosek 2016/04/20 15:59:44 I've followed the pattern used in other .gni files Show quoted text On 2016/04/20 05:38:45, kjellander (chromium) wrote: > Shouldn't "Exclude" be "Include" here? I've followed the pattern used in other .gni files in //build_overrides.
	6 gtest_include_multiprocess = true

	7

	8 # Exclude support for platform-specific operations across unit tests.
	kjellander_chromium 2016/04/20 05:38:45 Same here. Same here. Petr Hosek 2016/04/20 15:59:44 Ditto. Show quoted text On 2016/04/20 05:38:45, kjellander (chromium) wrote: > Same here. Ditto.
	9 gtest_include_platform_test = true

OLD	NEW

« no previous file with comments | « build/secondary/testing/gtest/BUILD.gn ('k') | no next file » | no next file with comments »