components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bmcquade@ review, cleanup Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_observer.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index aa146925d713a073770466c226e75f2d16c10c43..ee1cc6c0c2c8af3907c2710ef69f55c30ba2f461 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -65,8 +65,10 @@ void MetricsRenderFrameObserver::DidCommitProvisionalLoad(

// non-null, we will send metrics for the current page at some later time, as

// those metrics become available.

if (ShouldSendMetrics()) {

+ PageLoadTiming timing(GetTiming());

+ DCHECK(!timing.navigation_start.is_null());

page_timing_metrics_sender_.reset(

- new PageTimingMetricsSender(this, routing_id(), CreateTimer()));

+ new PageTimingMetricsSender(this, routing_id(), CreateTimer(), timing));

}