Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bmcquade@ review, cleanup Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h" 5 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 return; 58 return;
59 59
60 // Make sure to release the sender for a previous navigation, if we have one. 60 // Make sure to release the sender for a previous navigation, if we have one.
61 page_timing_metrics_sender_.reset(); 61 page_timing_metrics_sender_.reset();
62 62
63 // We only create a PageTimingMetricsSender if the page meets the criteria for 63 // We only create a PageTimingMetricsSender if the page meets the criteria for
64 // sending and recording metrics. Once page_timing_metrics_sender_ is 64 // sending and recording metrics. Once page_timing_metrics_sender_ is
65 // non-null, we will send metrics for the current page at some later time, as 65 // non-null, we will send metrics for the current page at some later time, as
66 // those metrics become available. 66 // those metrics become available.
67 if (ShouldSendMetrics()) { 67 if (ShouldSendMetrics()) {
68 PageLoadTiming timing(GetTiming());
69 DCHECK(!timing.navigation_start.is_null());
68 page_timing_metrics_sender_.reset( 70 page_timing_metrics_sender_.reset(
69 new PageTimingMetricsSender(this, routing_id(), CreateTimer())); 71 new PageTimingMetricsSender(this, routing_id(), CreateTimer(), timing));
70 } 72 }
71 } 73 }
72 74
73 void MetricsRenderFrameObserver::SendMetrics() { 75 void MetricsRenderFrameObserver::SendMetrics() {
74 if (!page_timing_metrics_sender_) 76 if (!page_timing_metrics_sender_)
75 return; 77 return;
76 if (HasNoRenderFrame()) 78 if (HasNoRenderFrame())
77 return; 79 return;
78 PageLoadTiming timing(GetTiming()); 80 PageLoadTiming timing(GetTiming());
79 page_timing_metrics_sender_->Send(timing); 81 page_timing_metrics_sender_->Send(timing);
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 return base::WrapUnique(new base::OneShotTimer); 143 return base::WrapUnique(new base::OneShotTimer);
142 } 144 }
143 145
144 bool MetricsRenderFrameObserver::HasNoRenderFrame() const { 146 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
145 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); 147 bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
146 DCHECK(!no_frame); 148 DCHECK(!no_frame);
147 return no_frame; 149 return no_frame;
148 } 150 }
149 151
150 } // namespace page_load_metrics 152 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698