Chromium Code Reviews| Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc |
| diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc |
| index 311d857a2066b369c15323c41cb789cb835d96de..66a5f35b1af304819d11efcb29f5ce4305eb6391 100644 |
| --- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc |
| +++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc |
| @@ -64,8 +64,10 @@ void MetricsRenderFrameObserver::DidCommitProvisionalLoad( |
| // non-null, we will send metrics for the current page at some later time, as |
| // those metrics become available. |
| if (ShouldSendMetrics()) { |
| + PageLoadTiming timing(GetTiming()); |
| + DCHECK(!timing.navigation_start.is_null()); |
|
Bryan McQuade
2016/04/21 20:50:41
yikes, is this a bug fix? good catch.
Charlie Harrison
2016/04/21 21:09:24
Not quite a bugfix, this bit of code is necessary
|
| page_timing_metrics_sender_.reset( |
| - new PageTimingMetricsSender(this, routing_id(), CreateTimer())); |
| + new PageTimingMetricsSender(this, routing_id(), CreateTimer(), timing)); |
| } |
| } |