[ Don't commit ] Add FromGWS variants to the AbortTiming metrics

components/page_load_metrics/renderer/metrics_render_frame_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
 
 #include <string>
 
 #include "base/time/time.h"
 #include "base/timer/timer.h"
@@ skipping 46 matching lines @@
     return;
 
   // Make sure to release the sender for a previous navigation, if we have one.
   page_timing_metrics_sender_.reset();
 
   // We only create a PageTimingMetricsSender if the page meets the criteria for
   // sending and recording metrics. Once page_timing_metrics_sender_ is
   // non-null, we will send metrics for the current page at some later time, as
   // those metrics become available.
   if (ShouldSendMetrics()) {
+    PageLoadTiming timing(GetTiming());
+    DCHECK(!timing.navigation_start.is_null());

[Bryan McQuade, 2016/04/21 20:50:41]

yikes, is this a bug fix? good catch.

[Charlie Harrison, 2016/04/21 21:09:24]

Not quite a bugfix, this bit of code is necessary so that we can bootstrap the
timer to send a provisional IPC to establish that the page load is being tracked
by the renderer. I was able to close a committed page that hadn't sent any IPCs,
so it didn't log any AfterCommit metrics.

     page_timing_metrics_sender_.reset(
-        new PageTimingMetricsSender(this, routing_id(), CreateTimer()));
+        new PageTimingMetricsSender(this, routing_id(), CreateTimer(), timing));
   }
 }
 
 void MetricsRenderFrameObserver::SendMetrics() {
   if (!page_timing_metrics_sender_)
     return;
   if (HasNoRenderFrame())
     return;
   PageLoadTiming timing(GetTiming());
   page_timing_metrics_sender_->Send(timing);
@@ skipping 61 matching lines @@
   return make_scoped_ptr(new base::OneShotTimer);
 }
 
 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
   bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
   DCHECK(!no_frame);
   return no_frame;
 }
 
 }  // namespace page_load_metrics