components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc - Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaks Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | components/page_load_metrics/browser/page_load_metrics_observer.h » ('j') | components/page_load_metrics/renderer/metrics_render_frame_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

index de1fc2668d382f3005c3994d276543b6ec2803a4..1fef567e2008faeb9513e1d2b81bb134ff79aa88 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

@@ -39,6 +39,7 @@ class TestPageLoadMetricsObserver : public PageLoadMetricsObserver {

observed_committed_urls_(observed_committed_urls) {}

void OnStart(content::NavigationHandle* navigation_handle,

+ content::WebContents* web_contents,

const GURL& currently_committed_url) override {

observed_committed_urls_->push_back(currently_committed_url);

}