base: Remove a copy of and copy ctor from SequenceAndSortKey.

base: Remove a copy of and copy ctor from SequenceAndSortKey.

This patch removes a copy of SequenceAndSortKey. As a result, the copy
ctor is no longer needed (there won't be an implicit one generated).

R=danakj, gab

Committed: https://crrev.com/fc05fd34560e44a262d55be0ff84771eaa76c4f5
Cr-Commit-Position: refs/heads/master@{#388340}

[vmpstr, 2016-04-19 20:10:53]

Please take a look.

[danakj, 2016-04-19 20:11:54]

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/priorit...
File base/task_scheduler/priority_queue.h (left):

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/priorit...
base/task_scheduler/priority_queue.h:36: SequenceAndSortKey(const
SequenceAndSortKey& other);
DISALLOW_COPY_AND_ASSIGN then?

[fdoray, 2016-04-19 20:14:13]

fdoray@chromium.org changed reviewers:
+ fdoray@chromium.org

[fdoray, 2016-04-19 20:14:14]

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/priorit...
File base/task_scheduler/priority_queue.h (left):

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/priorit...
base/task_scheduler/priority_queue.h:44: const SequenceSortKey sort_key;
Add:
private:
  DISALLOW_COPY_AND_ASSIGN(SequenceAndSortKey);

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_thread_pool.cc (right):

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_thread_pool.cc:261: return
sequence_and_sort_key.sequence;
The |sequence_and_sort_key| reference becomes invalid after the Pop(). Change
these lines to:

scoped_refptr<Sequence> sequence = sequence_and_sort_key.sequence;
transaction->Pop();
return sequence;

[vmpstr, 2016-04-19 20:14:17]

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/priorit...
File base/task_scheduler/priority_queue.h (left):

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/priorit...
base/task_scheduler/priority_queue.h:36: SequenceAndSortKey(const
SequenceAndSortKey& other);
On 2016/04/19 20:11:54, danakj wrote:
> DISALLOW_COPY_AND_ASSIGN then?

Done. I didn't do this initially, because it's unclear to me whether this is
meant to be non-copyable or it just happens that we're currently not doing any
copies.

[vmpstr, 2016-04-19 20:19:29]

PTAL

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_thread_pool.cc (right):

https://codereview.chromium.org/1901223003/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_thread_pool.cc:261: return
sequence_and_sort_key.sequence;
On 2016/04/19 20:14:13, fdoray wrote:
> The |sequence_and_sort_key| reference becomes invalid after the Pop(). Change
> these lines to:
> 
> scoped_refptr<Sequence> sequence = sequence_and_sort_key.sequence;
> transaction->Pop();
> return sequence;

Done.

[fdoray, 2016-04-19 20:22:29]

lgtm

[vmpstr, 2016-04-19 20:23:11]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-04-19 20:23:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901223003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901223003/40001

[danakj, 2016-04-19 20:24:35]

LGTM 2

[robliao, 2016-04-19 20:38:28]

robliao@chromium.org changed reviewers:
+ robliao@chromium.org

[robliao, 2016-04-19 20:38:29]

lgtm

[commit-bot: I haz the power, 2016-04-19 21:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:19:50]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vmpstr, 2016-04-19 21:21:39]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:22:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901223003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901223003/40001

[commit-bot: I haz the power, 2016-04-19 22:51:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:17:29]

Description was changed from

==========
base: Remove a copy of and copy ctor from SequenceAndSortKey.

This patch removes a copy of SequenceAndSortKey. As a result, the copy
ctor is no longer needed (there won't be an implicit one generated).

R=danakj, gab
==========

to

==========
base: Remove a copy of and copy ctor from SequenceAndSortKey.

This patch removes a copy of SequenceAndSortKey. As a result, the copy
ctor is no longer needed (there won't be an implicit one generated).

R=danakj, gab

Committed: https://crrev.com/fc05fd34560e44a262d55be0ff84771eaa76c4f5
Cr-Commit-Position: refs/heads/master@{#388340}
==========

[commit-bot: I haz the power, 2016-04-22 19:17:30]

Patchset 3 (id:??) landed as
https://crrev.com/fc05fd34560e44a262d55be0ff84771eaa76c4f5
Cr-Commit-Position: refs/heads/master@{#388340}