Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1901193002: Check null m_parent in PaintLayer::insertOnlyThisLayerAfterStyleChange() (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check null m_parent in PaintLayer::insertOnlyThisLayerAfterStyleChange() PaintLayer::m_parent may be nullptr if an orphan LayoutObject is set style causing it to create a layer. The problem was only detected by ubsan_vptr because though there was call to PaintLayer::enclosingSelfPaintingLayer() with null 'this', the method returns null without any actual harm :) BUG=604534 TEST=All tests pass with ubsan_vptr Committed: https://crrev.com/c24d1e3d26bcdd4fc4afbc579ec65fbaadd4fbfa Cr-Commit-Position: refs/heads/master@{#388286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
4 years, 8 months ago (2016-04-19 18:01:24 UTC) #2
pdr.
LGTM
4 years, 8 months ago (2016-04-19 18:29:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901193002/1
4 years, 8 months ago (2016-04-19 18:36:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 19:50:23 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c24d1e3d26bcdd4fc4afbc579ec65fbaadd4fbfa
Cr-Commit-Position: refs/heads/master@{#388286}

Powered by Google App Engine
This is Rietveld 408576698