Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1901193002: Check null m_parent in PaintLayer::insertOnlyThisLayerAfterStyleChange() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1318 matching lines...) Expand 10 before | Expand all | Expand 10 after
1329 // paint invalidation container. 1329 // paint invalidation container.
1330 bool didSetPaintInvalidation = false; 1330 bool didSetPaintInvalidation = false;
1331 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && !layoutObject()->is LayoutView() && layoutObject()->isRooted() && layoutObject()->styleRef().isStack ed()) { 1331 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && !layoutObject()->is LayoutView() && layoutObject()->isRooted() && layoutObject()->styleRef().isStack ed()) {
1332 const LayoutBoxModelObject& previousPaintInvalidationContainer = layoutO bject()->parent()->containerForPaintInvalidation(); 1332 const LayoutBoxModelObject& previousPaintInvalidationContainer = layoutO bject()->parent()->containerForPaintInvalidation();
1333 if (!previousPaintInvalidationContainer.styleRef().isStackingContext()) { 1333 if (!previousPaintInvalidationContainer.styleRef().isStackingContext()) {
1334 layoutObject()->invalidatePaintIncludingNonSelfPaintingLayerDescenda nts(previousPaintInvalidationContainer); 1334 layoutObject()->invalidatePaintIncludingNonSelfPaintingLayerDescenda nts(previousPaintInvalidationContainer);
1335 didSetPaintInvalidation = true; 1335 didSetPaintInvalidation = true;
1336 } 1336 }
1337 } 1337 }
1338 1338
1339 if (!didSetPaintInvalidation && isSelfPaintingLayer()) { 1339 if (!didSetPaintInvalidation && isSelfPaintingLayer() && m_parent) {
1340 if (PaintLayer* enclosingSelfPaintingLayer = m_parent->enclosingSelfPain tingLayer()) 1340 if (PaintLayer* enclosingSelfPaintingLayer = m_parent->enclosingSelfPain tingLayer())
1341 mergeNeedsPaintPhaseFlagsFrom(*enclosingSelfPaintingLayer); 1341 mergeNeedsPaintPhaseFlagsFrom(*enclosingSelfPaintingLayer);
1342 } 1342 }
1343 1343
1344 // Clear out all the clip rects. 1344 // Clear out all the clip rects.
1345 clipper().clearClipRectsIncludingDescendants(); 1345 clipper().clearClipRectsIncludingDescendants();
1346 } 1346 }
1347 1347
1348 // Returns the layer reached on the walk up towards the ancestor. 1348 // Returns the layer reached on the walk up towards the ancestor.
1349 static inline const PaintLayer* accumulateOffsetTowardsAncestor(const PaintLayer * layer, const PaintLayer* ancestorLayer, LayoutPoint& location) 1349 static inline const PaintLayer* accumulateOffsetTowardsAncestor(const PaintLayer * layer, const PaintLayer* ancestorLayer, LayoutPoint& location)
(...skipping 1583 matching lines...) Expand 10 before | Expand all | Expand 10 after
2933 2933
2934 void showLayerTree(const blink::LayoutObject* layoutObject) 2934 void showLayerTree(const blink::LayoutObject* layoutObject)
2935 { 2935 {
2936 if (!layoutObject) { 2936 if (!layoutObject) {
2937 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2937 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2938 return; 2938 return;
2939 } 2939 }
2940 showLayerTree(layoutObject->enclosingLayer()); 2940 showLayerTree(layoutObject->enclosingLayer());
2941 } 2941 }
2942 #endif 2942 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698