Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1901103006: Web MIDI: Replace ASSERT macros with DCHECK macros (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, chromium-reviews, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: Replace ASSERT macros with DCHECK macros Replace ASSERT like macros in modules/webmidi. - ASSERT -> DCHECK - ASSERT_NOT_REACHED -> NOTREACHED BUG=596760 Committed: https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47 Cr-Commit-Position: refs/heads/master@{#388706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901103006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901103006/1
4 years, 8 months ago (2016-04-21 03:35:50 UTC) #2
Takashi Toyoshima
PTAL
4 years, 8 months ago (2016-04-21 04:01:39 UTC) #5
tkent
lgtm
4 years, 8 months ago (2016-04-21 04:02:48 UTC) #6
haraken
LGTM
4 years, 8 months ago (2016-04-21 04:03:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 04:58:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901103006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901103006/1
4 years, 8 months ago (2016-04-21 06:45:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 06:49:07 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:32:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47
Cr-Commit-Position: refs/heads/master@{#388706}

Powered by Google App Engine
This is Rietveld 408576698