third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp - Issue 1901103006: Web MIDI: Replace ASSERT macros with DCHECK macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp

Issue 1901103006: Web MIDI: Replace ASSERT macros with DCHECK macros (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIController.cpp ('k') | third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp b/third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp

index b18e8c2c3c1ffa4188d15fe61cdc14fb238441cf..91c5d46c29f0fd82716566e5aca36c9e5b4f6749 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp

@@ -40,7 +40,7 @@ using PortState = MIDIAccessor::MIDIPortState;

MIDIInput* MIDIInput::create(MIDIAccess* access, const String& id, const String& manufacturer, const String& name, const String& version, PortState state)

{

- ASSERT(access);

+ DCHECK(access);

MIDIInput* input = new MIDIInput(access, id, manufacturer, name, version, state);

input->suspendIfNeeded();

return input;

@@ -76,7 +76,7 @@ bool MIDIInput::addEventListenerInternal(const AtomicString& eventType, EventLis

void MIDIInput::didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp)

{

- ASSERT(isMainThread());

+ DCHECK(isMainThread());

if (!length)

return;