Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: src/heap/mark-compact.cc

Issue 1900953003: Remove isolate arg from EmbedderHeapTracer methods. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index e1eaba0b92cf0a92bb6ceff2bd10a5dd6decdda8..83cb118b013361da902d692488589b4273a50605 100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -2024,8 +2024,7 @@ void MarkCompactCollector::ProcessEphemeralMarking(
DCHECK(marking_deque_.IsEmpty() && !marking_deque_.overflowed());
while (work_to_do) {
if (UsingEmbedderHeapTracer()) {
- embedder_heap_tracer()->TraceWrappersFrom(
- reinterpret_cast<v8::Isolate*>(isolate()), wrappers_to_trace_);
+ embedder_heap_tracer()->TraceWrappersFrom(wrappers_to_trace_);
wrappers_to_trace_.clear();
} else if (!only_process_harmony_weak_collections) {
isolate()->global_handles()->IterateObjectGroups(
@@ -2219,8 +2218,7 @@ void MarkCompactCollector::MarkLiveObjects() {
TRACE_GC(heap()->tracer(),
GCTracer::Scope::MC_MARK_WEAK_CLOSURE_EPHEMERAL);
if (UsingEmbedderHeapTracer()) {
- embedder_heap_tracer()->TracePrologue(
- reinterpret_cast<v8::Isolate*>(isolate()));
+ embedder_heap_tracer()->TracePrologue();
}
ProcessEphemeralMarking(&root_visitor, false);
ProcessMarkingDeque();
@@ -2259,8 +2257,7 @@ void MarkCompactCollector::MarkLiveObjects() {
ProcessEphemeralMarking(&root_visitor, true);
ProcessMarkingDeque();
if (UsingEmbedderHeapTracer()) {
- embedder_heap_tracer()->TraceEpilogue(
- reinterpret_cast<v8::Isolate*>(isolate()));
+ embedder_heap_tracer()->TraceEpilogue();
}
}
}
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698