Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: include/v8.h

Issue 1900953003: Remove isolate arg from EmbedderHeapTracer methods. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 38f43abd509264f91f0b8a92645260886979f5a3..51fb1330614237fe6a1e735d9ff5d44798fd552e 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -5413,17 +5413,16 @@ enum class MemoryPressureLevel { kNone, kModerate, kCritical };
* trace through its heap and call PersistentBase::RegisterExternalReference on
* each js object reachable from any of the given wrappers.
*
- * Before the first call to the TraceWrappersFrom function v8 will call
- * TracePrologue. When the v8 garbage collection is finished, v8 will call
- * TraceEpilogue.
+ * Before the first call to the TraceWrappersFrom function TracePrologue will be
+ * called. When the garbage collection cycle is finished, TraceEpilogue will be
+ * called.
*/
class EmbedderHeapTracer {
public:
/**
* V8 will call this method at the beginning of the gc cycle.
*/
- virtual void TracePrologue(Isolate* isolate) = 0;
-
+ virtual void TracePrologue() = 0;
/**
* V8 will call this method with internal fields of a potential wrappers.
* Embedder is expected to trace its heap (synchronously) and call
@@ -5431,13 +5430,12 @@ class EmbedderHeapTracer {
* any of the given wrappers.
*/
virtual void TraceWrappersFrom(
- Isolate* isolate,
const std::vector<std::pair<void*, void*> >& internal_fields) = 0;
/**
* V8 will call this method at the end of the gc cycle. Allocation is *not*
* allowed in the TraceEpilogue.
*/
- virtual void TraceEpilogue(Isolate* isolate) = 0;
+ virtual void TraceEpilogue() = 0;
protected:
virtual ~EmbedderHeapTracer() = default;
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698