Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1900953003: Remove isolate arg from EmbedderHeapTracer methods. (Closed)

Created:
4 years, 8 months ago by Marcel Hlopko
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove isolate arg from EmbedderHeapTracer methods. As the code on the blink side sits down, we realize we don't need isolate arg anymore. As the heap tracer is set per isolate, it can actually be confusing if the isolate passed as argument is always the same as the isolate the heap tracer was set for. Wdyt? BUG=468240 LOG=no Committed: https://crrev.com/39939eebf84e8f62b9fffa46b0e18563e800516e Cr-Commit-Position: refs/heads/master@{#35620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M include/v8.h View 2 chunks +5 lines, -7 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Marcel Hlopko
Ptal
4 years, 8 months ago (2016-04-19 11:11:14 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-19 12:26:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900953003/1
4 years, 8 months ago (2016-04-19 12:26:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 12:53:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:55:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39939eebf84e8f62b9fffa46b0e18563e800516e
Cr-Commit-Position: refs/heads/master@{#35620}

Powered by Google App Engine
This is Rietveld 408576698