Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1900953002: Mojo C++ bindings: make SyncHandleRegistry a ref-counted object. (Closed)

Created:
4 years, 8 months ago by yzshen1
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: make SyncHandleRegistry a ref-counted object. This CL changes SyncHandleRegistry from an object destroyed during message loop shutdown to a ref-counted object, so that users don't have to worry about message loop shutdown. BUG=604762 Committed: https://crrev.com/1714061d91fe5ec9e20506a76e05e7681e68ad8d Cr-Commit-Position: refs/heads/master@{#388333}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -36 lines) Patch
M content/renderer/usb/web_usb_client_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_registry.h View 4 chunks +6 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_registry.cc View 4 chunks +7 lines, -21 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_watcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_watcher.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (14 generated)
yzshen1
Hi, Ken. Please take a look. Thanks!
4 years, 8 months ago (2016-04-19 00:01:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900953002/1
4 years, 8 months ago (2016-04-19 16:05:59 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-19 16:12:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900953002/20001
4 years, 8 months ago (2016-04-19 16:17:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/56247)
4 years, 8 months ago (2016-04-19 18:16:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900953002/20001
4 years, 8 months ago (2016-04-19 18:28:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/56430)
4 years, 8 months ago (2016-04-19 20:38:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900953002/20001
4 years, 8 months ago (2016-04-19 20:43:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/56525)
4 years, 8 months ago (2016-04-19 21:22:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900953002/20001
4 years, 8 months ago (2016-04-19 21:27:11 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 22:37:03 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:17:16 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1714061d91fe5ec9e20506a76e05e7681e68ad8d
Cr-Commit-Position: refs/heads/master@{#388333}

Powered by Google App Engine
This is Rietveld 408576698