Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1900743004: Store WideString, not raw pointer, in FX_TXTRUN (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Store WideString, not raw pointer, in FX_TXTRUN Storing raw pointers in structs is a questionable idea, given that we've got string classes to auto-manage lifetimes of the underlying storage. Also, return FX_TXTRUN while we're at it, since we count on RVO removing copies nowadays. BUG=pdfium:480 Committed: https://pdfium.googlesource.com/pdfium/+/d403329fa818ffd650221cee366c837f867e3df6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -34 lines) Patch
M xfa/fde/tto/fde_textout.cpp View 2 chunks +11 lines, -10 lines 0 comments Download
M xfa/fee/fde_txtedtpage.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M xfa/fgas/layout/fgas_textbreak.h View 1 chunk +16 lines, -18 lines 0 comments Download
M xfa/fgas/layout/fgas_textbreak.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, please review. Speculative fix for bug 480.
4 years, 6 months ago (2016-04-19 17:21:22 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-04-19 17:44:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900743004/1
4 years, 6 months ago (2016-04-19 19:03:01 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-04-19 19:03:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d403329fa818ffd650221cee366c837f867e...

Powered by Google App Engine
This is Rietveld 408576698