Store WideString, not raw pointer, in FX_TXTRUN

Store WideString, not raw pointer, in FX_TXTRUN

Storing raw pointers in structs is a questionable idea, given
that we've got string classes to auto-manage lifetimes of the
underlying storage.

Also, return FX_TXTRUN while we're at it, since we count on RVO
removing copies nowadays.

BUG=pdfium:480
Committed: https://pdfium.googlesource.com/pdfium/+/d403329fa818ffd650221cee366c837f867e3df6

[Tom Sepez, 2016-04-19 17:21:21]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-19 17:21:22]

Lei, please review.  Speculative fix for bug 480.

[Tom Sepez, 2016-04-19 17:22:32]

Description was changed from

==========
Store WideString, not raw pointer, in FX_TXTRUN

Storing raw pointers in structs is a questionable idea, given
that we've got string classes to auto-manage lifetimes of the
underlying storage.

BUG=pdfium:480
==========

to

==========
Store WideString, not raw pointer, in FX_TXTRUN

Storing raw pointers in structs is a questionable idea, given
that we've got string classes to auto-manage lifetimes of the
underlying storage.

Also, return FX_TXTRUN while we're at it, since we count on RVO
removing copies nowdays.

BUG=pdfium:480
==========

[Tom Sepez, 2016-04-19 17:22:42]

Description was changed from

==========
Store WideString, not raw pointer, in FX_TXTRUN

Storing raw pointers in structs is a questionable idea, given
that we've got string classes to auto-manage lifetimes of the
underlying storage.

Also, return FX_TXTRUN while we're at it, since we count on RVO
removing copies nowdays.

BUG=pdfium:480
==========

to

==========
Store WideString, not raw pointer, in FX_TXTRUN

Storing raw pointers in structs is a questionable idea, given
that we've got string classes to auto-manage lifetimes of the
underlying storage.

Also, return FX_TXTRUN while we're at it, since we count on RVO
removing copies nowadays.

BUG=pdfium:480
==========

[Lei Zhang, 2016-04-19 17:44:54]

lgtm

[Tom Sepez, 2016-04-19 19:02:58]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-19 19:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900743004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900743004/1

[commit-bot: I haz the power, 2016-04-19 19:03:18]

Description was changed from

==========
Store WideString, not raw pointer, in FX_TXTRUN

Storing raw pointers in structs is a questionable idea, given
that we've got string classes to auto-manage lifetimes of the
underlying storage.

Also, return FX_TXTRUN while we're at it, since we count on RVO
removing copies nowadays.

BUG=pdfium:480
==========

to

==========
Store WideString, not raw pointer, in FX_TXTRUN

Storing raw pointers in structs is a questionable idea, given
that we've got string classes to auto-manage lifetimes of the
underlying storage.

Also, return FX_TXTRUN while we're at it, since we count on RVO
removing copies nowadays.

BUG=pdfium:480

Committed:
https://pdfium.googlesource.com/pdfium/+/d403329fa818ffd650221cee366c837f867e...
==========

[commit-bot: I haz the power, 2016-04-19 19:03:18]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d403329fa818ffd650221cee366c837f867e...