xfa/fee/fde_txtedtpage.cpp - Issue 1900743004: Store WideString, not raw pointer, in FX_TXTRUN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fee/fde_txtedtpage.cpp

Issue 1900743004: Store WideString, not raw pointer, in FX_TXTRUN (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fee/fde_txtedtpage.cpp

diff --git a/xfa/fee/fde_txtedtpage.cpp b/xfa/fee/fde_txtedtpage.cpp

index eaf2627b56224a2cafbd3f59498cfbb5fe033ec3..4aadb397da3918a12e29d4292c25aea214ba1b0e 100644

--- a/xfa/fee/fde_txtedtpage.cpp

+++ b/xfa/fee/fde_txtedtpage.cpp

@@ -81,8 +81,6 @@ int32_t CFDE_TxtEdtTextSet::GetDisplayPos(FDE_HVISUALOBJ hText,

FX_TXTRUN tr;

tr.pAccess = m_pPage;

tr.pIdentity = (void*)hText;

- tr.pStr = NULL;

- tr.pWidths = NULL;

tr.iLength = nLength;

tr.pFont = pTextParams->pFont;

tr.fFontSize = pTextParams->fFontSize;

@@ -114,8 +112,6 @@ int32_t CFDE_TxtEdtTextSet::GetCharRects_Impl(FDE_HVISUALOBJ hText,