chromeos: Delete old, unused contacts code.

chrome/common/autocomplete_match_type.h

Index: chrome/common/autocomplete_match_type.h
diff --git a/chrome/common/autocomplete_match_type.h b/chrome/common/autocomplete_match_type.h
index 5842270e29076f0fc81defb65ddd15e082ef4eda..2f84bbf706b7259d5bb8155bf01bf48936c3c868 100644
--- a/chrome/common/autocomplete_match_type.h
+++ b/chrome/common/autocomplete_match_type.h
@@ -34,7 +34,6 @@ struct AutocompleteMatchType {
     SEARCH_OTHER_ENGINE,         // A search with a non-default engine.
     EXTENSION_APP,               // An Extension App with a title/url that
                                  // contains the input.
-    CONTACT,                     // One of the user's contacts.

[Mark P, 2014/03/07 17:20:14]

I know nothing in the comments makes this clear, but we recently discovered that
you cannot rename or renumber the entries in this enum because the values are
stored in the ShortcutsDatabase.  (Deleting this will cause BOOKMARK_TITLE
shortcuts to be mislabeled.)  Instead, simply rename this enum
DEPRECATED_CONTACT

[Peter Kasting, 2014/03/07 17:43:53]

Well, you can delete it, you just need to renumber anything in the database with
a higher number.

In this case that's actually probably preferred, since if we're removing support
for this type entirely, we should probably write a migration pass that nukes any
entries of this type out of the database.

[Mark P, 2014/03/07 18:53:22]

Personally, I'd rather leave an obsolete enum value / enum hole than bloat
Chrome permanently with code for a migration pass.

[Daniel Erat, 2014/03/07 21:52:57]

Done.

[Peter Kasting, 2014/03/07 22:09:55]

Migration passes aren't permanent.  We're supposed to rip them out after a year
or so.  (After I get done removing command-line flags I might have to start on
the "remove migration passes" task.)

Anyway, I'm still worried about ripping out code that deals with this enum value
but still having its entries in the database.  Makes me nervous.

     BOOKMARK_TITLE,              // A bookmark whose title contains the input.
     NUM_TYPES,
   };