chromeos: Delete old, unused contacts code.

chrome/common/autocomplete_match_type.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_AUTOCOMPLETE_MATCH_TYPE_H_
 #define CHROME_COMMON_AUTOCOMPLETE_MATCH_TYPE_H_
 
 #include <string>
 
 struct AutocompleteMatchType {
@@ skipping 16 matching lines @@
                                  // specific suggestion categories below.
     SEARCH_SUGGEST_ENTITY,       // A suggested search for an entity.
     SEARCH_SUGGEST_INFINITE,     // A suggested search to complete the tail of
                                  // the query.
     SEARCH_SUGGEST_PERSONALIZED, // A personalized suggested search.
     SEARCH_SUGGEST_PROFILE,      // A personalized suggested search for a
                                  // Google+ profile.
     SEARCH_OTHER_ENGINE,         // A search with a non-default engine.
     EXTENSION_APP,               // An Extension App with a title/url that
                                  // contains the input.
-    CONTACT,                     // One of the user's contacts.

[Mark P, 2014/03/07 17:20:14]

I know nothing in the comments makes this clear, but we recently discovered that
you cannot rename or renumber the entries in this enum because the values are
stored in the ShortcutsDatabase.  (Deleting this will cause BOOKMARK_TITLE
shortcuts to be mislabeled.)  Instead, simply rename this enum
DEPRECATED_CONTACT

[Peter Kasting, 2014/03/07 17:43:53]

Well, you can delete it, you just need to renumber anything in the database with
a higher number.

In this case that's actually probably preferred, since if we're removing support
for this type entirely, we should probably write a migration pass that nukes any
entries of this type out of the database.

[Mark P, 2014/03/07 18:53:22]

Personally, I'd rather leave an obsolete enum value / enum hole than bloat
Chrome permanently with code for a migration pass.

[Daniel Erat, 2014/03/07 21:52:57]

Done.

[Peter Kasting, 2014/03/07 22:09:55]

Migration passes aren't permanent.  We're supposed to rip them out after a year
or so.  (After I get done removing command-line flags I might have to start on
the "remove migration passes" task.)

Anyway, I'm still worried about ripping out code that deals with this enum value
but still having its entries in the database.  Makes me nervous.

     BOOKMARK_TITLE,              // A bookmark whose title contains the input.
     NUM_TYPES,
   };
 
   // Converts |type| to a string representation. Used in logging.
   static std::string ToString(AutocompleteMatchType::Type type);
 };
 
 #endif  // CHROME_COMMON_AUTOCOMPLETE_MATCH_TYPE_H_