Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1900343003: Provide currently_committed_url to PageLoadMetricsObservers (Closed)

Created:
4 years, 8 months ago by jkarlin
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Provide currently_committed_url to PageLoadMetricsObservers This allows us to track metrics based on where the user is navigating from. A referer can be used to accomplish this in some cases, though referers are not always available or may be sanitized to include only the origin in some cases. BUG=603948 Review URL: https://codereview.chromium.org/1879413002 Cr-Commit-Position: refs/heads/master@{#387649} (cherry picked from commit 003fade38f4d89100f517a6469abeb84cd9db165) Committed: https://chromium.googlesource.com/chromium/src/+/0c2396d866a38f3f3a25f46c332d56cf4c69d67e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -62 lines) Patch
M components/page_load_metrics/browser/metrics_web_contents_observer.h View 3 chunks +10 lines, -5 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc View 12 chunks +85 lines, -44 lines 0 comments Download
M components/page_load_metrics/browser/page_load_metrics_observer.h View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkarlin
4 years, 8 months ago (2016-04-20 13:41:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c2396d866a38f3f3a25f46c332d56cf4c69d67e.

Powered by Google App Engine
This is Rietveld 408576698