Provide currently_committed_url to PageLoadMetricsObservers

Provide currently_committed_url to PageLoadMetricsObservers

This allows us to track metrics based on where the user is navigating from.
A referer can be used to accomplish this in some cases, though referers
are not always available or may be sanitized to include only the origin
in some cases.

BUG=603948
Committed: https://crrev.com/003fade38f4d89100f517a6469abeb84cd9db165
Cr-Commit-Position: refs/heads/master@{#387649}

[Bryan McQuade, 2016-04-15 16:33:10]

Description was changed from

==========
Infra for GWS metrics.

BUG=
==========

to

==========
Provide currently_committed_url to PageLoadMetricsObservers

This allows us to track metrics based on where the user is navigating from.
A referer can be used to accomplish this in some cases, though referers
are not always available or may be sanitized to include only the origin
in some cases.

BUG=603948
==========

[Bryan McQuade, 2016-04-15 16:40:29]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2016-04-15 16:51:38]

LGTM with comment.

https://codereview.chromium.org/1879413002/diff/100001/components/page_load_m...
File components/page_load_metrics/browser/metrics_web_contents_observer.h
(right):

https://codereview.chromium.org/1879413002/diff/100001/components/page_load_m...
components/page_load_metrics/browser/metrics_web_contents_observer.h:110: //
currently_committed_load_or_null beyond the scope of the constructor.
Might as well as the same thing about the NavigationHandle while you're at it.

[Bryan McQuade, 2016-04-15 17:21:44]

Thanks! Updated comment. Will commit now.

https://codereview.chromium.org/1879413002/diff/100001/components/page_load_m...
File components/page_load_metrics/browser/metrics_web_contents_observer.h
(right):

https://codereview.chromium.org/1879413002/diff/100001/components/page_load_m...
components/page_load_metrics/browser/metrics_web_contents_observer.h:110: //
currently_committed_load_or_null beyond the scope of the constructor.
On 2016/04/15 at 16:51:38, csharrison wrote:
> Might as well as the same thing about the NavigationHandle while you're at it.

Done

[Bryan McQuade, 2016-04-15 17:22:25]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-04-15 17:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/1879413002/#ps120001
(title: "address")

[commit-bot: I haz the power, 2016-04-15 17:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879413002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879413002/120001

[commit-bot: I haz the power, 2016-04-15 18:21:55]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-15 18:22:58]

Description was changed from

==========
Provide currently_committed_url to PageLoadMetricsObservers

This allows us to track metrics based on where the user is navigating from.
A referer can be used to accomplish this in some cases, though referers
are not always available or may be sanitized to include only the origin
in some cases.

BUG=603948
==========

to

==========
Provide currently_committed_url to PageLoadMetricsObservers

This allows us to track metrics based on where the user is navigating from.
A referer can be used to accomplish this in some cases, though referers
are not always available or may be sanitized to include only the origin
in some cases.

BUG=603948

Committed: https://crrev.com/003fade38f4d89100f517a6469abeb84cd9db165
Cr-Commit-Position: refs/heads/master@{#387649}
==========

[commit-bot: I haz the power, 2016-04-15 18:22:59]

Patchset 7 (id:??) landed as
https://crrev.com/003fade38f4d89100f517a6469abeb84cd9db165
Cr-Commit-Position: refs/heads/master@{#387649}