Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1900233005: I18n the message about managing passwords online. (Closed)

Created:
4 years, 8 months ago by hcarmona
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

I18n the message about managing passwords online. BUG=546836 Committed: https://crrev.com/fa5a8f4090c9372358a69dc6401b29b3c672d4c5 Cr-Commit-Position: refs/heads/master@{#388631}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hcarmona
PTAL
4 years, 8 months ago (2016-04-20 20:58:43 UTC) #3
dschuyler
LGTM with nit. https://codereview.chromium.org/1900233005/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1900233005/diff/1/chrome/app/settings_strings.grdp#newcode199 chrome/app/settings_strings.grdp:199: </message> nit: I think the space ...
4 years, 8 months ago (2016-04-20 22:05:30 UTC) #4
hcarmona
Fixed nit. Committing. https://codereview.chromium.org/1900233005/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1900233005/diff/1/chrome/app/settings_strings.grdp#newcode199 chrome/app/settings_strings.grdp:199: </message> On 2016/04/20 22:05:29, dschuyler wrote: ...
4 years, 8 months ago (2016-04-20 22:33:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900233005/20001
4 years, 8 months ago (2016-04-20 22:34:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 00:26:39 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:47 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fa5a8f4090c9372358a69dc6401b29b3c672d4c5
Cr-Commit-Position: refs/heads/master@{#388631}

Powered by Google App Engine
This is Rietveld 408576698