Issue 19002005: Share Custom Element registration contexts between related documents.

Issue 19002005: Share Custom Element registration contexts between related documents. (Closed)

Created:
7 years, 5 months ago by dominicc (has gone to gerrit)

Modified:
7 years, 5 months ago

Reviewers:
dglazkov, abarth-chromium

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Share Custom Element registration contexts between related documents. This is based on the draft spec and (admittedly incomplete) proposals being discussed here: <https://dvcs.w3.org/hg/webcomponents/raw-file/default/spec/custom/index.html#terminology>; <https://www.w3.org/Bugs/Public/show_bug.cgi?id=22485>; <https://www.w3.org/Bugs/Public/show_bug.cgi?id=22466>; This does not do any special handling when elements move between documents in different registration contexts yet. BUG=247219

Patch Set 1 #

Patch Set 2 : Tweak the test to do lazy wrapping in both cases. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+433 lines, -17 lines)			Patch
A	LayoutTests/fast/dom/custom/registration-context-sharing.html	View	1	1 chunk	+182 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/custom/registration-context-sharing-expected.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/CustomElementConstructorBuilder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/CustomElementConstructorBuilder.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/core.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	Source/core/dom/CustomElementRegistrationContextualizer.h	View		1 chunk	+73 lines, -0 lines	0 comments	Download
A	Source/core/dom/CustomElementRegistrationContextualizer.cpp	View		1 chunk	+135 lines, -0 lines	0 comments	Download
M	Source/core/dom/CustomElementRegistry.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/DOMImplementation.cpp	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View		5 chunks	+9 lines, -8 lines	0 comments	Download
M	Source/core/editing/markup.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLImportsController.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/DOMPatchSupport.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/loader/DocumentLoader.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/xml/DOMParser.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequest.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/xml/XSLTProcessor.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/xml/XSLTProcessor.cpp	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dglazkov

I wonder if the approach in the patch https://codereview.chromium.org/18808004/ (slicing into the process of creating ...

7 years, 5 months ago (2013-07-12 17:50:33 UTC) #2

dominicc (has gone to gerrit)

7 years, 5 months ago (2013-07-12 20:43:33 UTC) #3

Wow, looks neat. Let me close this and wait until that goes in.

Expand Messages | Collapse Messages