Macro-based constraints

Macro-based constraints

State: Proof of concept. Not commit-ready.

This Cl introduces a single source of truth for what constraints
exist, and uses that to generate code for the various places
that have to do something for every defined constraint.

BUG=

[hta - Chromium, 2016-04-21 12:35:28]

Description was changed from

==========
Macro-based constraints

State: Proof of concept. Not commit-ready.

This Cl introduces a single source of truth for what constraints
exist, and uses that to generate code for the various places
that have to do something for every defined constraint.

BUG=
==========

to

==========
Macro-based constraints

State: Proof of concept. Not commit-ready.

This Cl introduces a single source of truth for what constraints
exist, and uses that to generate code for the various places
that have to do something for every defined constraint.

BUG=
==========

[hta - Chromium, 2016-04-21 12:35:29]

hta@chromium.org changed reviewers:
+ tommi@chromium.org

[hta - Chromium, 2016-04-21 12:35:42]

Thoughts?

[hta - Chromium, 2016-04-21 17:45:03]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 17:45:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899943008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899943008/1

[commit-bot: I haz the power, 2016-04-21 19:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 19:14:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hta - Chromium, 2016-04-21 21:20:54]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 21:21:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899943008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899943008/20001

[commit-bot: I haz the power, 2016-04-21 22:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:47:04]

Dry run: This issue passed the CQ dry run.

[tommi (sloooow) - chröme, 2016-05-01 17:52:16]

https://codereview.chromium.org/1899943008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
(right):

https://codereview.chromium.org/1899943008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp:518: if
(constraintsIn.has##uppercase()) { \
crazy question.  Instead of all of these type specific getters and setters,
would it be easier if the type was always base::Value? (see src/base/values.h)

[hta - Chromium, 2016-05-02 08:22:00]

No magic bullet found yet....

https://codereview.chromium.org/1899943008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
(right):

https://codereview.chromium.org/1899943008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp:518: if
(constraintsIn.has##uppercase()) { \
On 2016/05/01 17:52:16, tommi-chrömium wrote:
> crazy question.  Instead of all of these type specific getters and setters,
> would it be easier if the type was always base::Value? (see src/base/values.h)

two problems with that:

- the constraints types aren't simple types, they're max/min/exact/ideal or
multivalues (ConstrainXXX rather than just XXX)
- the chief API I'm struggling with is the API generated by the WebIDL compiler.
I've tried to not go into changing that.

some of the #datatype# calls can be eliminated by templating. But not the
data-declaration one; that has to have the type because that's what tells C++
which type each constraint has.

[tommi (sloooow) - chröme, 2016-05-03 16:49:35]

https://codereview.chromium.org/1899943008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
(right):

https://codereview.chromium.org/1899943008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp:518: if
(constraintsIn.has##uppercase()) { \
On 2016/05/02 08:22:00, hta - Chromium wrote:
> On 2016/05/01 17:52:16, tommi-chrömium wrote:
> > crazy question.  Instead of all of these type specific getters and setters,
> > would it be easier if the type was always base::Value? (see
src/base/values.h)
> 
> two problems with that:
> 
> - the constraints types aren't simple types, they're max/min/exact/ideal or
> multivalues (ConstrainXXX rather than just XXX)
> - the chief API I'm struggling with is the API generated by the WebIDL
compiler.
> I've tried to not go into changing that.
> 
> some of the #datatype# calls can be eliminated by templating. But not the
> data-declaration one; that has to have the type because that's what tells C++
> which type each constraint has.

What I'm wondering is if it would make more sense to do something similar to the
stats value type in webrtc:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

Then add to that the 'has' and 'get' methods.

[hta - Chromium, 2016-08-03 09:03:19]

hta@chromium.org changed reviewers:
+ foolip@chromium.org