Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1899903002: Assert that AudioContext::destination() is not called from the audio thread (Closed)

Created:
4 years, 8 months ago by Raymond Toy
Modified:
4 years, 8 months ago
Reviewers:
hongchan
CC:
Raymond Toy, blink-reviews, chromium-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert that AudioContext::destination() is not called from the audio thread Add assertion and comment that AudioContext::destination() cannot be called from the audio thread and explain why. BUG=604477, 561295 TEST=none Committed: https://crrev.com/bb4ad50fdcd777b451d98690e9ccf6b2c6677ea5 Cr-Commit-Position: refs/heads/master@{#388069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Raymond Toy
PTAL
4 years, 8 months ago (2016-04-18 20:32:13 UTC) #3
hongchan
lgtm
4 years, 8 months ago (2016-04-18 20:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899903002/1
4 years, 8 months ago (2016-04-18 20:54:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:15:27 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:16:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb4ad50fdcd777b451d98690e9ccf6b2c6677ea5
Cr-Commit-Position: refs/heads/master@{#388069}

Powered by Google App Engine
This is Rietveld 408576698