Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

Issue 1899903002: Assert that AudioContext::destination() is not called from the audio thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
index 853d94dc7c116ab93063c9d5120ffc20b6527f40..c06e0f313b3e05e5522b98f37e393674c471479c 100644
--- a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
@@ -189,6 +189,14 @@ bool AbstractAudioContext::hasPendingActivity() const
return !m_isCleared;
}
+AudioDestinationNode* AbstractAudioContext::destination() const
+{
+ // Cannot be called from the audio thread because this method touches objects managed by Oilpan,
+ // and the audio thread is not managed by Oilpan.
+ ASSERT(!isAudioThread());
+ return m_destinationNode.get();
+}
+
void AbstractAudioContext::throwExceptionForClosedState(ExceptionState& exceptionState)
{
exceptionState.throwDOMException(InvalidStateError, "AudioContext has been closed.");
« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698