content/public/browser/web_contents.h - Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents.h

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use HasSubstr instead of ContainsRegex when appropriate. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/web_contents.h

diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h

index eb0da0053015e6628ce668f844482e4f5700d8b4..54e46245871357fd09b56321598ae4bba99bede9 100644

--- a/content/public/browser/web_contents.h

+++ b/content/public/browser/web_contents.h

@@ -542,6 +542,7 @@ class WebContents : public PageNavigator,

// Generate an MHTML representation of the current page in the given file.

virtual void GenerateMHTML(

const base::FilePath& file,

+ bool use_binary_encoding,

nasko 2016/04/20 17:01:15 Please add a comment about what the new parameter

dewittj 2016/04/20 20:20:59 Done.

const base::Callback<void(int64_t /* size of the file */)>& callback) = 0;

// Returns the contents MIME type after a navigation.

« content/browser/download/save_package.cc ('K') | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »