Offline Pages: Use 'binary encoding' to create MHTML, instead of base64.

content/browser/download/save_package.cc

Index: content/browser/download/save_package.cc
diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc
index b13a01e88c08f140a0139fd4c1be3e548c476f86..002bb7b4412bb1edc6b2f2ffe2710cf69cd436c9 100644
--- a/content/browser/download/save_package.cc
+++ b/content/browser/download/save_package.cc
@@ -338,8 +338,9 @@ void SavePackage::InitWithDownloadItem(
     DCHECK(!saved_main_directory_path_.empty());
     GetSavableResourceLinks();
   } else if (save_type_ == SAVE_PAGE_TYPE_AS_MHTML) {
-    web_contents()->GenerateMHTML(saved_main_file_path_, base::Bind(
-        &SavePackage::OnMHTMLGenerated, this));
+    web_contents()->GenerateMHTML(
+        saved_main_file_path_, /* use_binary_encoding = */ false,

[nasko, 2016/04/20 17:01:15]

nit: Comment for the name of parameter should go after the value.

[dewittj, 2016/04/20 20:20:59]

I will make the change, but there isn't anywhere in the style guide that
suggests this, in fact the only example has preceding (see Function Argument
Comments).

[nasko, 2016/04/20 22:22:38]

I'm going with consistency across code in content/, especially prevalent in IPC
message files. Example:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/fr...

+        base::Bind(&SavePackage::OnMHTMLGenerated, this));
   } else {
     DCHECK_EQ(SAVE_PAGE_TYPE_AS_ONLY_HTML, save_type_);
     wait_state_ = NET_FILES;