Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1899303004: Move //third_party/webrtc deps under enable_webrtc (Closed)

Created:
4 years, 8 months ago by mbjorge
Modified:
4 years, 8 months ago
Reviewers:
slan, brettw, pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move //third_party/webrtc deps under enable_webrtc BUG=None Committed: https://crrev.com/cbac8086b384be0f26f4a8c99c25e6a9f19f420d Cr-Commit-Position: refs/heads/master@{#388650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mbjorge
I think https://codereview.chromium.org/1817903002 should have put this here originally when it was added to clean ...
4 years, 8 months ago (2016-04-20 01:14:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899303004/1
4 years, 8 months ago (2016-04-20 01:17:51 UTC) #4
slan
lgtm
4 years, 8 months ago (2016-04-20 01:17:57 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 02:16:22 UTC) #7
brettw
lgtm
4 years, 8 months ago (2016-04-20 17:38:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899303004/1
4 years, 8 months ago (2016-04-21 01:03:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 01:14:36 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:29:51 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cbac8086b384be0f26f4a8c99c25e6a9f19f420d
Cr-Commit-Position: refs/heads/master@{#388650}

Powered by Google App Engine
This is Rietveld 408576698