Remove special-code for paginating floats followed by lines of text.

Remove special-code for paginating floats followed by lines of text.

If a float is pushed to the next fragmentainer, we used to push any lines
established by consecutive sibling content along with it, even if they would
fit in the previous fragmentainer. As a contrast to this, we did not do the
same to consecutive blocks - only to lines!

What blocks do makes the most sense [1]. Do the same for lines.

[1] Discussed here: https://lists.w3.org/Archives/Public/www-style/2015Sep/0002.html

Added two new tests. The one that has a block with text following a float also
worked before this CL, but I added it to demonstrate how ridiculous it is to
behave differently here, simply depending on whether it's a line or a block.

Some existing tests needed an update, because they depended on the previous
behavior.

Committed: https://crrev.com/046282e7297e25453ff3a589675dc618a5cc4a90
Cr-Commit-Position: refs/heads/master@{#388701}

[mstensho (USE GERRIT), 2016-04-20 22:01:18]

mstensho@opera.com changed reviewers:
+ leviw@chromium.org

[mstensho (USE GERRIT), 2016-04-20 22:01:18]

I started by replacing positionNewFloatOnLine(applesauce, balderdash, baloney,
width) with 
positionNewFloats(&width). Some hopefully rusty bits and pieces fell off the
code here and there as a result.

[leviw_travelin_and_unemployed, 2016-04-20 22:09:24]

leviw@chromium.org changed reviewers:
+ szager@chromium.org, wkorman@chromium.org

[leviw_travelin_and_unemployed, 2016-04-20 22:09:41]

leviw@chromium.org changed reviewers:
+ eae@chromium.org

[leviw_travelin_and_unemployed, 2016-04-20 22:10:03]

lgtm

[leviw_travelin_and_unemployed, 2016-04-20 22:11:03]

Sorry, I got a little click-happy there and didn't type my message yet....

I'm trying to cc folks who may eventually be reviewing these sorts of patches.
This one is awesome, btw.

[mstensho (USE GERRIT), 2016-04-21 04:16:23]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-04-21 04:16:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899193007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899193007/1

[commit-bot: I haz the power, 2016-04-21 05:18:37]

Committed patchset #1 (id:1)

[eae, 2016-04-21 16:25:25]

LGTM

[commit-bot: I haz the power, 2016-04-22 19:31:50]

Description was changed from

==========
Remove special-code for paginating floats followed by lines of text.

If a float is pushed to the next fragmentainer, we used to push any lines
established by consecutive sibling content along with it, even if they would
fit in the previous fragmentainer. As a contrast to this, we did not do the
same to consecutive blocks - only to lines!

What blocks do makes the most sense [1]. Do the same for lines.

[1] Discussed here:
https://lists.w3.org/Archives/Public/www-style/2015Sep/0002.html

Added two new tests. The one that has a block with text following a float also
worked before this CL, but I added it to demonstrate how ridiculous it is to
behave differently here, simply depending on whether it's a line or a block.

Some existing tests needed an update, because they depended on the previous
behavior.
==========

to

==========
Remove special-code for paginating floats followed by lines of text.

If a float is pushed to the next fragmentainer, we used to push any lines
established by consecutive sibling content along with it, even if they would
fit in the previous fragmentainer. As a contrast to this, we did not do the
same to consecutive blocks - only to lines!

What blocks do makes the most sense [1]. Do the same for lines.

[1] Discussed here:
https://lists.w3.org/Archives/Public/www-style/2015Sep/0002.html

Added two new tests. The one that has a block with text following a float also
worked before this CL, but I added it to demonstrate how ridiculous it is to
behave differently here, simply depending on whether it's a line or a block.

Some existing tests needed an update, because they depended on the previous
behavior.

Committed: https://crrev.com/046282e7297e25453ff3a589675dc618a5cc4a90
Cr-Commit-Position: refs/heads/master@{#388701}
==========

[commit-bot: I haz the power, 2016-04-22 19:31:51]

Patchset 1 (id:??) landed as
https://crrev.com/046282e7297e25453ff3a589675dc618a5cc4a90
Cr-Commit-Position: refs/heads/master@{#388701}