third_party/WebKit/Source/core/layout/FloatingObjects.h - Issue 1899193007: Remove special-code for paginating floats followed by lines of text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/FloatingObjects.h

Issue 1899193007: Remove special-code for paginating floats followed by lines of text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fragmentation/unbreakable-tall-float-before-line-expected.html ('k') | third_party/WebKit/Source/core/layout/FloatingObjects.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/FloatingObjects.h

diff --git a/third_party/WebKit/Source/core/layout/FloatingObjects.h b/third_party/WebKit/Source/core/layout/FloatingObjects.h

index e465f4043140bbad667f5f0069c6091768a8c6cc..0da336dc7cbfe7bd768ab146b15603d4ef1e26b4 100644

--- a/third_party/WebKit/Source/core/layout/FloatingObjects.h

+++ b/third_party/WebKit/Source/core/layout/FloatingObjects.h

@@ -72,9 +72,6 @@ public:

const LayoutRect& frameRect() const { ASSERT(isPlaced()); return m_frameRect; }

- int paginationStrut() const { return m_paginationStrut; }

- void setPaginationStrut(int strut) { m_paginationStrut = strut; }

#if ENABLE(ASSERT)

bool isInPlacedTree() const { return m_isInPlacedTree; }

void setIsInPlacedTree(bool value) { m_isInPlacedTree = value; }

@@ -98,7 +95,6 @@ private:

LayoutBox* m_layoutObject;

RootInlineBox* m_originatingLine;

LayoutRect m_frameRect;

- int m_paginationStrut; // FIXME: Is this class size-sensitive? Does this need 32-bits?

unsigned m_type : 2; // Type (left or right aligned)

unsigned m_shouldPaint : 1;