Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1899183002: [heap] Disallow allocation on the last page in address range (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, danno, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Disallow allocation on the last page in address range BUG= Committed: https://crrev.com/871d0603d8ba3a9777b8b0935885c8240962adda Cr-Commit-Position: refs/heads/master@{#35656}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : SetCC to LeaveCC on arm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
Hannes Payer (out of office)
LGTM As discussed offline, I would move the logic to AllocateChunk which is a lower-level ...
4 years, 8 months ago (2016-04-19 12:25:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899183002/40001
4 years, 8 months ago (2016-04-19 12:47:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 13:13:05 UTC) #6
Michael Lippautz
+danno, +bmeurer: fyi general: - mips uses unsigned arithmetic which should've always been safe as ...
4 years, 8 months ago (2016-04-19 18:06:47 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899183002/60001
4 years, 8 months ago (2016-04-20 11:58:39 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 12:28:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899183002/60001
4 years, 8 months ago (2016-04-20 12:59:26 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-20 13:01:26 UTC) #17
nodir1
4 years, 8 months ago (2016-04-22 18:44:07 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/871d0603d8ba3a9777b8b0935885c8240962adda
Cr-Commit-Position: refs/heads/master@{#35656}

Powered by Google App Engine
This is Rietveld 408576698