src/ia32/macro-assembler-ia32.cc - Issue 1899183002: [heap] Disallow allocation on the last page in address range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 1899183002: [heap] Disallow allocation on the last page in address range (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: SetCC to LeaveCC on arm Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 2f013c8b55f998ae48bfce1a67ed23abb778efb7..42d4415c5bb4d9cef0641558726ebde939dd3d0d 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -1572,7 +1572,6 @@ void MacroAssembler::Allocate(int object_size,

mov(top_reg, result);

}

add(top_reg, Immediate(object_size));

- j(carry, gc_required);

cmp(top_reg, Operand::StaticVariable(allocation_limit));

j(above, gc_required);

« no previous file with comments | « src/heap/spaces.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »