Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Unified Diff: components/update_client/update_client_unittest.cc

Issue 1899043002: Implement ping_freshness for update_client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/update_checker_unittest.cc ('k') | components/update_client/update_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_client_unittest.cc
diff --git a/components/update_client/update_client_unittest.cc b/components/update_client/update_client_unittest.cc
index 8e8c9432153f7560eb148a368203dc153964340b..1bdfa2f1b9dd0919b8df0377ae526f9d74f7b6c7 100644
--- a/components/update_client/update_client_unittest.cc
+++ b/components/update_client/update_client_unittest.cc
@@ -148,7 +148,7 @@ class UpdateClientTest : public testing::Test {
static base::FilePath TestFilePath(const char* file);
scoped_refptr<update_client::Configurator> config() { return config_; }
- const update_client::PersistedData& metadata() { return *metadata_; }
+ update_client::PersistedData* metadata() { return metadata_.get(); }
base::Closure quit_closure() { return quit_closure_; }
@@ -227,7 +227,7 @@ TEST_F(UpdateClientTest, OneCrxNoUpdate) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -334,7 +334,7 @@ TEST_F(UpdateClientTest, TwoCrxUpdateNoUpdate) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -520,7 +520,7 @@ TEST_F(UpdateClientTest, TwoCrxUpdate) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -768,7 +768,7 @@ TEST_F(UpdateClientTest, TwoCrxUpdateDownloadTimeout) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -1019,7 +1019,7 @@ TEST_F(UpdateClientTest, OneCrxDiffUpdate) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -1311,7 +1311,7 @@ TEST_F(UpdateClientTest, OneCrxInstallError) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -1495,7 +1495,7 @@ TEST_F(UpdateClientTest, OneCrxDiffUpdateFailsFullUpdateSucceeds) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -1785,7 +1785,7 @@ TEST_F(UpdateClientTest, OneCrxNoUpdateQueuedCall) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -1885,7 +1885,7 @@ TEST_F(UpdateClientTest, OneCrxInstall) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -2072,7 +2072,7 @@ TEST_F(UpdateClientTest, ConcurrentInstallSameCRX) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -2166,7 +2166,7 @@ TEST_F(UpdateClientTest, EmptyIdList) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
@@ -2212,7 +2212,7 @@ TEST_F(UpdateClientTest, SendUninstallPing) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return nullptr;
}
@@ -2310,7 +2310,7 @@ TEST_F(UpdateClientTest, RetryAfter) {
public:
static scoped_ptr<UpdateChecker> Create(
const scoped_refptr<Configurator>& config,
- const PersistedData& metadata) {
+ PersistedData* metadata) {
return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
}
« no previous file with comments | « components/update_client/update_checker_unittest.cc ('k') | components/update_client/update_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698