Implement ping_freshness for update_client.

components/update_client/update_client_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 130 matching lines @@
   UpdateClientTest();
   ~UpdateClientTest() override;
 
  protected:
   void RunThreads();
 
   // Returns the full path to a test file.
   static base::FilePath TestFilePath(const char* file);
 
   scoped_refptr<update_client::Configurator> config() { return config_; }
-  const update_client::PersistedData& metadata() { return *metadata_; }
+  update_client::PersistedData* metadata() { return metadata_.get(); }
 
   base::Closure quit_closure() { return quit_closure_; }
 
  private:
   static const int kNumWorkerThreads_ = 2;
 
   base::MessageLoopForUI message_loop_;
   base::RunLoop runloop_;
   base::Closure quit_closure_;
 
@@ skipping 58 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE,
           base::Bind(update_check_callback, 0, UpdateResponse::Results(), 0));
@@ skipping 86 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
@@ skipping 165 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
@@ skipping 227 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
@@ skipping 230 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       static int num_call = 0;
       ++num_call;
 
@@ skipping 271 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
@@ skipping 163 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       static int num_call = 0;
       ++num_call;
 
@@ skipping 269 matching lines @@
 
       if (num_call == 2)
         quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE,
           base::Bind(update_check_callback, 0, UpdateResponse::Results(), 0));
@@ skipping 79 matching lines @@
     static void Callback(const base::Closure& quit_closure, int error) {
       EXPECT_EQ(0, error);
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
@@ skipping 166 matching lines @@
         EXPECT_EQ(0, error);
         quit_closure.Run();
       }
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE,
           base::Bind(update_check_callback, 0, UpdateResponse::Results(), 0));
@@ skipping 73 matching lines @@
   class CompletionCallbackFake {
    public:
     static void Callback(const base::Closure& quit_closure, int error) {
       quit_closure.Run();
     }
   };
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       return false;
     }
   };
@@ skipping 25 matching lines @@
       empty_id_list, base::Bind(&DataCallbackFake::Callback),
       base::Bind(&CompletionCallbackFake::Callback, runloop.QuitClosure()));
   runloop.Run();
 }
 
 TEST_F(UpdateClientTest, SendUninstallPing) {
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return nullptr;
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       return false;
     }
   };
@@ skipping 77 matching lines @@
       }
 
       quit_closure.Run();
     }
   };
 
   class FakeUpdateChecker : public UpdateChecker {
    public:
     static scoped_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
-        const PersistedData& metadata) {
+        PersistedData* metadata) {
       return scoped_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
         const UpdateCheckCallback& update_check_callback) override {
       static int num_call = 0;
       ++num_call;
 
@@ skipping 105 matching lines @@
     update_client->Update(
         ids, base::Bind(&DataCallbackFake::Callback),
         base::Bind(&CompletionCallbackFake::Callback, runloop.QuitClosure()));
     runloop.Run();
   }
 
   update_client->RemoveObserver(&observer);
 }
 
 }  // namespace update_client