Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1898873003: Add ReadableStream operations to use it from Fetch API (Closed)

Created:
4 years, 8 months ago by yhirano
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, blink-review-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@body-stream-buffer-test-refactoring
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ReadableStream operations to use it from Fetch API This CL adds some ReadableStream operations as a preparation for using it from Fetch API (from BodyStreamBuffer, in particular). BUG=596832 Committed: https://crrev.com/9e0854ce1c44879edf75a8f7bfd936498b863f3c Cr-Commit-Position: refs/heads/master@{#388421}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M third_party/WebKit/Source/core/streams/ReadableStream.js View 3 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamOperations.h View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp View 1 2 chunks +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp View 1 chunk +52 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
yhirano
ccing blink-review-bindings as this change is bindings related.
4 years, 8 months ago (2016-04-19 08:34:55 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm
4 years, 8 months ago (2016-04-19 08:47:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898873003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898873003/40001
4 years, 8 months ago (2016-04-20 03:28:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-20 03:32:26 UTC) #9
domenic
I am curious how SetReadableStreamDisturbed is going to be used. It seems like using it ...
4 years, 8 months ago (2016-04-20 20:41:17 UTC) #10
yhirano
On 2016/04/20 20:41:17, domenic wrote: > I am curious how SetReadableStreamDisturbed is going to be ...
4 years, 8 months ago (2016-04-21 00:06:16 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:20:42 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e0854ce1c44879edf75a8f7bfd936498b863f3c
Cr-Commit-Position: refs/heads/master@{#388421}

Powered by Google App Engine
This is Rietveld 408576698