Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 189883010: hide getTotalClip, so we can eventually remove it (Closed)

Created:
6 years, 9 months ago by reed2
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

hide getTotalClip, so we can eventually remove it hide getClipType, so we can eventually remove it patch from issue 189443007 TBR=robertphilips@google.com Committed: http://code.google.com/p/skia/source/detail?r=13715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -21 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 3 chunks +17 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 5 chunks +23 lines, -7 lines 0 comments Download
M src/utils/SkCanvasStateUtils.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/CanvasTest.cpp View 6 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed2
The CQ bit was checked by reed@chromium.org
6 years, 9 months ago (2014-03-08 03:42:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/189883010/1
6 years, 9 months ago (2014-03-08 03:42:26 UTC) #2
reed2
change from first CL -- fixed SkNullCanvas.h in experimental
6 years, 9 months ago (2014-03-08 03:44:45 UTC) #3
commit-bot: I haz the power
Change committed as 13715
6 years, 9 months ago (2014-03-08 03:57:23 UTC) #4
reed2
6 years, 9 months ago (2014-03-08 12:23:40 UTC) #5
Message was sent while issue was closed.
I think this Cl is incomplete.

It seems that there is a suite of APIs around the state of the current clip:
- isClipEmpty
- isClipRect
- getClipDeviceBounds (returns false on empty)
- getClipLocalBounds (returns false on empty)
[- getClipType]
[- getTotalClip]

It seems like there need only be 1 or maybe 2 virtuals here, and that the other
can be non-virtual helpers. 
My goals for a future CL would be:
- reduce # of virtuals to make subclassing easier/clearer
- organize the methods themselves to make it clearer to a Client how they relate
to each other

Powered by Google App Engine
This is Rietveld 408576698