net/quic/quic_headers_stream_test.cc - Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_headers_stream_test.cc

Issue 1898793003: Make QuicDispatcher's helper and alarm factory arguments unique_ptrs to make ownership clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: fixing rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_headers_stream_test.cc

diff --git a/net/quic/quic_headers_stream_test.cc b/net/quic/quic_headers_stream_test.cc

index e02f53077088acc6574e66c3016e799fff900012..1954d912b517010988cd3097d6888370e48da955 100644

--- a/net/quic/quic_headers_stream_test.cc

+++ b/net/quic/quic_headers_stream_test.cc

@@ -133,6 +133,7 @@ class QuicHeadersStreamTest : public ::testing::TestWithParam<TestParams> {

public:

QuicHeadersStreamTest()

: connection_(new StrictMock<MockConnection>(&helper_,

+ &alarm_factory_,

perspective(),

GetVersion())),

session_(connection_),

@@ -249,6 +250,7 @@ class QuicHeadersStreamTest : public ::testing::TestWithParam<TestParams> {

static const bool kHasPriority = true;

MockConnectionHelper helper_;

+ MockAlarmFactory alarm_factory_;

StrictMock<MockConnection>* connection_;

StrictMock<MockQuicSpdySession> session_;

QuicHeadersStream* headers_stream_;

« no previous file with comments | « net/quic/quic_flow_controller_test.cc ('k') | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »