Remove testharness.js and friends in LayoutTests/http/tests/.

Remove testharness.js and friends in LayoutTests/http/tests/.

Map them to corresponding files in LayoutTests/imported/web-platform-tests/resources/.

BUG=604329
Committed: https://crrev.com/a3508259c067a39fb74f5f32afc6210b302e12cf
Cr-Commit-Position: refs/heads/master@{#388068}

[tkent, 2016-04-18 12:57:46]

Patchset #1 (id:1) has been deleted

[tkent, 2016-04-18 14:02:38]

Patchset #1 (id:20001) has been deleted

[tkent, 2016-04-18 15:25:44]

tkent@chromium.org changed reviewers:
+ dpranke@chromium.org, jsbell@chromium.org

[tkent, 2016-04-18 15:25:44]

jsbell@ or dpranke@, would you review this please?

[jsbell, 2016-04-18 16:28:20]

One advantage to keeping the imported version separate is that an import will
never cause changes outside the imported directory. And if we move to imports
being e.g. under third_party then mapping that directory in gets a little
stranger. But I'm more in favor of reducing duplication and keeping our copy of
testharness.js up to date, so I'm okay with this direction.

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/local/formdata/formdata-methods.html
(right):

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/local/formdata/formdata-methods.html:3:
<script src="../../../../resources/testharness.js"></script>
I don't understand this - since this file is not 4 levels deep under http/tests
why do we need four ../ ? When served as HTTP this should be the same as
../../resources or just /resources

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/local/serviceworker/fetch-request-body-file.html
(right):

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/local/serviceworker/fetch-request-body-file.html:2:
<script src="../../../../resources/testharness.js"></script>
Same here

[Dirk Pranke, 2016-04-18 17:38:20]

Is WebIDLParser.js no longer used?

[jsbell, 2016-04-18 17:39:46]

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
(right):

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py:81:
'-c', 'Alias /w3c/resources/WebIDLParser.js "%s/webidl2/lib/webidl2.js"' %
imported_resources_dir,
WebIDLParser.js is automagically made available here.

[Dirk Pranke, 2016-04-18 17:44:31]

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
(right):

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py:81:
'-c', 'Alias /w3c/resources/WebIDLParser.js "%s/webidl2/lib/webidl2.js"' %
imported_resources_dir,
On 2016/04/18 17:39:46, jsbell wrote:
> WebIDLParser.js is automagically made available here.

Ah, right.

[tkent, 2016-04-18 21:07:34]

On 2016/04/18 at 16:28:20, jsbell wrote:
> One advantage to keeping the imported version separate is that an import will
never cause changes outside the imported directory. And if we move to imports
being e.g. under third_party then mapping that directory in gets a little
stranger. But I'm more in favor of reducing duplication and keeping our copy of
testharness.js up to date, so I'm okay with this direction.

ok, so we might have two testharness.js in the future; one rolled by DPES and
one checked-in to our repo.
I can change this CL so that LayoutTests/http uses LayoutTests/resources/
instead of LayoutTests/imported/wpt/resources.

[tkent, 2016-04-18 21:07:41]

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/local/formdata/formdata-methods.html
(right):

https://codereview.chromium.org/1898703003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/local/formdata/formdata-methods.html:3:
<script src="../../../../resources/testharness.js"></script>
On 2016/04/18 at 16:28:20, jsbell wrote:
> I don't understand this - since this file is not 4 levels deep under
http/tests why do we need four ../ ? When served as HTTP this should be the same
as ../../resources or just /resources

Tess in http/tests/local run without a web server.  So these tests needs to use
LayoutTests/resources/ or LayoutTests/imported/wpt/resources/.

[jsbell, 2016-04-18 21:11:22]

On 2016/04/18 21:07:41, tkent wrote:
> Tess in http/tests/local run without a web server.

o_O (learn something new every day...)

lgtm

[Dirk Pranke, 2016-04-18 21:44:54]

lgtm

[tkent, 2016-04-18 23:08:37]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-04-18 23:09:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898703003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898703003/40001

[commit-bot: I haz the power, 2016-04-18 23:14:11]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-04-18 23:16:23]

Description was changed from

==========
Remove testharness.js and friends in LayoutTests/http/tests/.

Map them to corresponding files in
LayoutTests/imported/web-platform-tests/resources/.

BUG=604329
==========

to

==========
Remove testharness.js and friends in LayoutTests/http/tests/.

Map them to corresponding files in
LayoutTests/imported/web-platform-tests/resources/.

BUG=604329

Committed: https://crrev.com/a3508259c067a39fb74f5f32afc6210b302e12cf
Cr-Commit-Position: refs/heads/master@{#388068}
==========

[commit-bot: I haz the power, 2016-04-18 23:16:24]

Patchset 1 (id:??) landed as
https://crrev.com/a3508259c067a39fb74f5f32afc6210b302e12cf
Cr-Commit-Position: refs/heads/master@{#388068}