third_party/WebKit/LayoutTests/http/tests/local/formdata/formdata-methods.html - Issue 1898703003: Remove testharness.js and friends in LayoutTests/http/tests/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/local/formdata/formdata-methods.html

Issue 1898703003: Remove testharness.js and friends in LayoutTests/http/tests/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/PRESUBMIT.py ('k') | third_party/WebKit/LayoutTests/http/tests/local/serviceworker/fetch-request-body-file.html » ('j') | third_party/WebKit/LayoutTests/http/tests/local/serviceworker/fetch-request-body-file.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>FormData interface</title>	2 <title>FormData interface</title>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../../../resources/testharness.js"></script>
	jsbell 2016/04/18 16:28:20 I don't understand this - since this file is not 4 I don't understand this - since this file is not 4 levels deep under http/tests why do we need four ../ ? When served as HTTP this should be the same as ../../resources or just /resources tkent 2016/04/18 21:07:41 Tess in http/tests/local run without a web server. Show quoted text On 2016/04/18 at 16:28:20, jsbell wrote: > I don't understand this - since this file is not 4 levels deep under http/tests why do we need four ../ ? When served as HTTP this should be the same as ../../resources or just /resources Tess in http/tests/local run without a web server. So these tests needs to use LayoutTests/resources/ or LayoutTests/imported/wpt/resources/.
4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../../../resources/testharnessreport.js"></script>

5 <script>	5 <script>

6	6

7 // Helpers	7 // Helpers

8	8

9 function serializeFormData(formData)	9 function serializeFormData(formData)

10 {	10 {

11 return new Promise(function(resolve, reject) {	11 return new Promise(function(resolve, reject) {

12 var xhr = new XMLHttpRequest(), async = true;	12 var xhr = new XMLHttpRequest(), async = true;

13 xhr.open(	13 xhr.open(

14 'POST',	14 'POST',

(...skipping 375 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
390 var values = [];	390 var values = [];

391 for(var entry of fd.values())	391 for(var entry of fd.values())

392 values.push(entry);	392 values.push(entry);

393 assert_array_equals(values, expected_values,	393 assert_array_equals(values, expected_values,

394 'values() iterator should see non-deleted values');	394 'values() iterator should see non-deleted values');

395 }());	395 }());

396	396

397 }, 'FormData - iterators');	397 }, 'FormData - iterators');

398	398

399 </script>	399 </script>

OLD	NEW