Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3570)

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 1898633004: Views: Add new SetFocusBehavior method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_selector_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_selector_view.cc b/chrome/browser/ui/views/website_settings/permission_selector_view.cc
index 1968f3c90bc59e2cc118219f4afeecc69ce5ec55..6e34c9ae77b3e40f62f9996fde78647cea595c72 100644
--- a/chrome/browser/ui/views/website_settings/permission_selector_view.cc
+++ b/chrome/browser/ui/views/website_settings/permission_selector_view.cc
@@ -71,6 +71,7 @@ PermissionMenuButton::PermissionMenuButton(const base::string16& text,
// be available, and the button would get native GTK styling on Linux.
UpdateThemedBorder();
+ SetFocusBehavior(FocusBehavior::ALWAYS);
sky 2016/04/21 16:44:17 Why the change here?
karandeepb 2016/04/22 08:38:29 Trent in his review had suggested moving this to t
is_rtl_display_ =
base::i18n::RIGHT_TO_LEFT == base::i18n::GetStringDirection(text);
}
@@ -178,7 +179,6 @@ PermissionSelectorView::PermissionSelectorView(
permission.source),
menu_model_.get(), button_enabled);
menu_button_->SetEnabled(button_enabled);
- menu_button_->SetFocusable(button_enabled);
menu_button_->SetAccessibleName(
WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
layout->AddView(menu_button_);

Powered by Google App Engine
This is Rietveld 408576698