Views: Add new SetFocusBehavior method.

chrome/browser/ui/views/website_settings/permission_selector_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/permission_selector_view.h"
 
 #include "base/i18n/rtl.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
@@ skipping 53 matching lines @@
 PermissionMenuButton::PermissionMenuButton(const base::string16& text,
                                            PermissionMenuModel* model,
                                            bool show_menu_marker)
     : MenuButton(text, this, show_menu_marker), menu_model_(model) {
   // Update the themed border before the NativeTheme is applied. Usually this
   // happens in a call to LabelButton::OnNativeThemeChanged(). However, if
   // PermissionMenuButton called that from its override, the NativeTheme would
   // be available, and the button would get native GTK styling on Linux.
   UpdateThemedBorder();
 
+  SetFocusBehavior(FocusBehavior::ALWAYS);

[sky, 2016/04/21 16:44:17]

Why the change here?

[karandeepb, 2016/04/22 08:38:29]

Trent in his review had suggested moving this to the PermissionMenuButton
constructor. PermissionMenuButton is only instantiated once, so either should be
ok.

   is_rtl_display_ =
       base::i18n::RIGHT_TO_LEFT == base::i18n::GetStringDirection(text);
 }
 
 PermissionMenuButton::~PermissionMenuButton() {
 }
 
 void PermissionMenuButton::GetAccessibleState(ui::AXViewState* state) {
   MenuButton::GetAccessibleState(state);
   state->value = GetText();
@@ skipping 87 matching lines @@
                  base::Unretained(this))));
   // Create the permission menu button.
   bool button_enabled =
       permission.source == content_settings::SETTING_SOURCE_USER;
   menu_button_ = new internal::PermissionMenuButton(
       WebsiteSettingsUI::PermissionActionToUIString(
           permission.type, permission.setting, permission.default_setting,
           permission.source),
       menu_model_.get(), button_enabled);
   menu_button_->SetEnabled(button_enabled);
-  menu_button_->SetFocusable(button_enabled);
   menu_button_->SetAccessibleName(
       WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
   layout->AddView(menu_button_);
 }
 
 void PermissionSelectorView::AddObserver(
     PermissionSelectorViewObserver* observer) {
   observer_list_.AddObserver(observer);
 }
 
@@ skipping 18 matching lines @@
   // Update the menu button text to reflect the new setting.
   menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString(
       permission.type, permission.setting, permission.default_setting,
       content_settings::SETTING_SOURCE_USER));
   menu_button_->SizeToPreferredSize();
 
   FOR_EACH_OBSERVER(PermissionSelectorViewObserver,
                     observer_list_,
                     OnPermissionChanged(permission));
 }