Views: Add new SetFocusBehavior method.

ash/sticky_keys/sticky_keys_overlay.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/sticky_keys/sticky_keys_overlay.h"
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/sticky_keys/sticky_keys_controller.h"
 #include "base/strings/string_util.h"
@@ skipping 49 matching lines @@
 };
 
 StickyKeyOverlayLabel::StickyKeyOverlayLabel(const std::string& key_name)
     : state_(STICKY_KEY_STATE_DISABLED) {
   ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
 
   SetText(base::UTF8ToUTF16(key_name));
   SetHorizontalAlignment(gfx::ALIGN_LEFT);
   SetFontList(rb->GetFontList(kKeyLabelFontStyle));
   SetAutoColorReadabilityEnabled(false);
-  SetFocusable(false);
+  SetFocusBehavior(FocusBehavior::NEVER);

[Evan Stade, 2016/04/20 21:17:03]

isn't NEVER the default? Why do you have to call this at all (here or elsewhere)

[karandeepb, 2016/04/21 03:16:33]

Yeah NEVER is the default. This was just refactoring the original code. The call
here is actually redundant. I think there are two reasons as to why we may use
FocusBehavior::NEVER-

1) Sometimes, as in this case, it is just to be more explicit. 
2) Also, it can be used to override the focus setting of the base class. Eg See
the SetFocusable call in ash/system/date/date_view.cc.

[Evan Stade, 2016/04/25 21:30:52]

I think we should remove it because I don't see it as more explicit, I see it as
more confusing (the old code had this problem too).

[Evan Stade, 2016/04/25 21:32:33]

oh, and maybe we can get rid of NEVER, as far as the public api is concerned. I
could imagine a valid use case for it but I also doubt that any valid uses
actually exist.

   SetEnabledColor(SkColorSetARGB(0x80, 0xFF, 0xFF, 0xFF));
   SetDisabledColor(SkColorSetARGB(0x80, 0xFF, 0xFF, 0xFF));
   SetSubpixelRenderingEnabled(false);
 }
 
 StickyKeyOverlayLabel::~StickyKeyOverlayLabel() {
 }
 
 void StickyKeyOverlayLabel::SetKeyState(StickyKeyState state) {
   state_ = state;
@@ skipping 235 matching lines @@
   ui::LayerAnimator* animator = overlay_widget_->GetLayer()->GetAnimator();
   if (animator)
     animator->RemoveObserver(this);
 }
 
 void StickyKeysOverlay::OnLayerAnimationScheduled(
     ui::LayerAnimationSequence* sequence) {
 }
 
 }  // namespace ash