chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc - Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing

Patch Set: Add invalidate call. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc ('K') | « chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h ('k') | chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc

diff --git a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc

index 0485116072eb6d9fbed0afeffddd5b5f0d7ba05f..dd21eba5c25f2d68314e61320b6c316aaffa6d76 100644

--- a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc

+++ b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc

@@ -103,7 +103,11 @@ void SafePicasaAlbumTableReader::OnParsePicasaPMPDatabaseFinished(

MediaFileSystemBackend::MediaTaskRunner()->PostTask(

FROM_HERE,

- base::Bind(callback_, parse_success, albums, folders));

+ base::Bind(callback_,

+ scoped_refptr<SafePicasaAlbumTableReader>(this),

vandebo (ex-Chrome) 2013/07/11 16:56:27 make_scoped_refptr might be easier here.

tommycli 2013/07/11 21:19:17 Done.

+ parse_success,

+ albums,

+ folders));

parser_state_ = FINISHED_PARSING_STATE;

}