Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h"
 
 #include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
 #include "chrome/common/chrome_utility_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_data.h"
@@ skipping 85 matching lines @@
 void SafePicasaAlbumTableReader::OnParsePicasaPMPDatabaseFinished(
     bool parse_success,
     const std::vector<AlbumInfo>& albums,
     const std::vector<AlbumInfo>& folders) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (parser_state_ != STARTED_PARSING_STATE)
     return;
 
   MediaFileSystemBackend::MediaTaskRunner()->PostTask(
       FROM_HERE,
-      base::Bind(callback_, parse_success, albums, folders));
+      base::Bind(callback_,
+                 scoped_refptr<SafePicasaAlbumTableReader>(this),

[vandebo (ex-Chrome), 2013/07/11 16:56:27]

make_scoped_refptr might be easier here.

[tommycli, 2013/07/11 21:19:17]

Done.

+                 parse_success,
+                 albums,
+                 folders));
   parser_state_ = FINISHED_PARSING_STATE;
 }
 
 void SafePicasaAlbumTableReader::OnProcessCrashed(int exit_code) {
   OnParsePicasaPMPDatabaseFinished(false, std::vector<AlbumInfo>(),
                                    std::vector<AlbumInfo>());
 }
 
 bool SafePicasaAlbumTableReader::OnMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(SafePicasaAlbumTableReader, message)
     IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ProcessStarted,
                         OnProcessStarted)
     IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParsePicasaPMPDatabase_Finished,
                         OnParsePicasaPMPDatabaseFinished)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 }  // namespace picasa